Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smart-tx opt in modal 2 #9661

Merged
merged 2 commits into from
May 17, 2024
Merged

feat: smart-tx opt in modal 2 #9661

merged 2 commits into from
May 17, 2024

Conversation

infiniteflower
Copy link
Contributor

Description

This PR adds some small changes to the STX Opt In Modal:

  • Updates the copy
  • Makes it not possible to close by accident

Related issues

n/a

Manual testing steps

  1. Install the extension from scratch
  2. Check the updated Opt In modal

Screenshots/Recordings

Before

After

Screenshot 2024-05-15 at 5 15 13 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@infiniteflower infiniteflower marked this pull request as ready for review May 17, 2024 01:55
@infiniteflower infiniteflower requested a review from a team as a code owner May 17, 2024 01:55
@infiniteflower infiniteflower changed the title Feat/smart tx opt in 2 feat: smart-tx opt in modal 2 May 17, 2024
@infiniteflower infiniteflower merged commit 1905195 into main May 17, 2024
37 of 38 checks passed
@infiniteflower infiniteflower deleted the feat/smart-tx-opt-in-2 branch May 17, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants