Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add send to saved contact e2e test #9708

Merged
merged 23 commits into from
May 23, 2024
Merged

test: add send to saved contact e2e test #9708

merged 23 commits into from
May 23, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented May 21, 2024 •
edited
Loading

Description

As the title says, this PR adds E2E coverage for sending funds to a saved contact.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this May 21, 2024
@cortisiko cortisiko added team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. labels May 21, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 65d2ad5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4184914f-5f0d-4459-8145-3a4ca74ac16b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 21, 2024
@cortisiko
Merge branch 'send-flow-create-send-flow-folder-with-the-respective-p…
09cf6db 
…age-objects' into detox/add-send-to-contact-e2e
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 09cf6db
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b850ae44-c7e0-4b98-abe2-e3be626a04ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Base automatically changed from send-flow-create-send-flow-folder-with-the-respective-page-objects to main May 22, 2024 03:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cortisiko cortisiko marked this pull request as ready for review May 22, 2024 18:53
@cortisiko cortisiko requested a review from a team as a code owner May 22, 2024 18:53
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 21ff954
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d6b4d26a-20ac-4a66-868d-d77605ef9681

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

chrisleewilcox
chrisleewilcox approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit d632331 into main May 23, 2024
37 checks passed
@cortisiko cortisiko deleted the detox/add-send-to-contact-e2e branch May 23, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

@cortisiko cortisiko

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cortisiko @chrisleewilcox @metamaskbot