Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gulp - clean and add "disc" analysis task #985

Merged
merged 5 commits into from Jan 10, 2017
Merged

Gulp - clean and add "disc" analysis task #985

merged 5 commits into from Jan 10, 2017

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Jan 10, 2017

No description provided.

danfinlay
danfinlay approved these changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I like disc, fun to have it as a task!

danfinlay
danfinlay requested changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the bug killing our CI tests.

gulpfile.js
})

var bundler = browserify(browserifyOpts)
bundler.transform('brfs')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually rely on brfs for our CI test suite.

@danfinlay
Copy link
Contributor

Oooh, if putting brfs in the package.json transforms instead of the gulpfile works, that's much cleaner!

@kumavis kumavis merged commit d52c046 into dev Jan 10, 2017
@kumavis kumavis deleted the gulp1 branch January 10, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kumavis @danfinlay @FlySwatter