Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature flag to disable Snap installation #2521

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

FrederikBolding
Copy link
Member

For certain platforms, we want to disable installation of external Snaps while allowing preinstalled Snaps. This PR adds a feature flag that disables installation of new Snaps.

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 26, 2024 09:38
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (049168b) to head (a4c00a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         442      442           
  Lines        9148     9151    +3     
  Branches     1416     1416           
=======================================
+ Hits         8637     8640    +3     
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 9b7a038 into main Jun 26, 2024
156 checks passed
@FrederikBolding FrederikBolding deleted the fb/snap-installation-feature-flag branch June 26, 2024 09:45
@wilfred1005
Copy link

2

@wilfred1005
Copy link

#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants