This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Adding mixHash to newHeads subscription output #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang implementation (geth) has, since v1.5.0, relied on the mixHash field to be present in the JSON representation of a block to calculate and verify the block hash.
See ethereum/go-ethereum#3230 for the discussion.
Eventhough this was not specified in the Ethereum JSON-RPC protocol this was recognized (openethereum/parity-ethereum#3148) by the Parity team and subsequently implemented and merged (openethereum/parity-ethereum#3169) into the Parity client.
When the websocket subprovider was implemented #189 it omitted the mixHash which results in the following error when using geth's ethclient.
This pull request adds the mixHash to the JSON output.