Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

deps: ws@^5.1.1->^7.5.9 #446

Merged
merged 1 commit into from
Oct 11, 2023
Merged

deps: ws@^5.1.1->^7.5.9 #446

merged 1 commit into from
Oct 11, 2023

Conversation

legobeat
Copy link
Collaborator

@legobeat legobeat commented Sep 6, 2023

Bumps the ws package to v7.

Lists of breaking changes in the package:

@legobeat legobeat requested a review from a team as a code owner September 6, 2023 03:03
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ws 5.2.3...7.5.9 network +0/-0 122 kB lpinca

@socket-security
Copy link

socket-security bot commented Sep 6, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: ws@7.5.9

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Collaborator Author

legobeat commented Sep 6, 2023

@SocketSecurity ignore ws@7.5.9

@legobeat legobeat requested a review from naugtur October 10, 2023 23:50
@legobeat legobeat mentioned this pull request Oct 11, 2023
5 tasks
@legobeat legobeat requested a review from mcmire October 11, 2023 23:08
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the breaking changes and they don't seem to affect this package.

@legobeat legobeat merged commit c850d58 into MetaMask:main Oct 11, 2023
3 checks passed
@legobeat legobeat mentioned this pull request Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants