Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

devDeps: ganache-core@2.13.2->ganache@^7.9.2 #473

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

legobeat
Copy link
Collaborator

@legobeat legobeat commented Apr 16, 2024

Copy link

socket-security bot commented Apr 16, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/assert@2.0.0
  • orphan: npm/assert@2.0.0
New author npm/semver@7.3.8
  • orphan: npm/semver@7.3.8
Mild CVE npm/semver@7.3.8
  • orphan: npm/semver@7.3.8
CVE npm/json5@2.2.1
  • orphan: npm/json5@2.2.1

Ignoring: npm/@trufflesuite/bigint-buffer@1.1.10, npm/@trufflesuite/uws-js-unofficial@20.30.0-unofficial.0, npm/bufferutil@4.0.5, npm/ganache@7.9.1, npm/leveldown@6.1.0, npm/minimist@1.2.7, npm/utf-8-validate@5.0.7, npm/utf-8-validate@6.0.3

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/assert@2.0.0
  • @SocketSecurity ignore npm/semver@7.3.8
  • @SocketSecurity ignore npm/json5@2.2.1

@legobeat legobeat mentioned this pull request Apr 16, 2024
3 tasks
@legobeat
Copy link
Collaborator Author

@SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@9.1.0
@SocketSecurity ignore npm/@metamask/safe-event-emitter@3.1.1
@SocketSecurity ignore npm/jsonify@0.0.1
@SocketSecurity ignore npm/minimist@1.2.7

new authors ok

@legobeat
Copy link
Collaborator Author

@SocketSecurity ignore npm/ganache@7.9.1

network access, native code ok

@legobeat
Copy link
Collaborator Author

@SocketSecurity ignore npm/@trufflesuite/uws-js-unofficial@20.30.0-unofficial.0

network access ok

@legobeat
Copy link
Collaborator Author

@SocketSecurity ignore npm/bufferutil@4.0.5
@SocketSecurity ignore npm/utf-8-validate@5.0.7
@SocketSecurity ignore npm/@trufflesuite/bigint-buffer@1.1.10
@SocketSecurity ignore npm/leveldown@6.1.0
@SocketSecurity ignore npm/utf-8-validate@6.0.3

native code ok

@legobeat
Copy link
Collaborator Author

Note: The remaining Socket Security alerts are false flags - the highlighted versions are not actually included here.

@legobeat legobeat marked this pull request as ready for review April 17, 2024 08:29
@legobeat legobeat requested a review from a team as a code owner April 17, 2024 08:29
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 0e45c90 into MetaMask:main Apr 17, 2024
7 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants