Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug with pagination and filterreset - change GET to Slug-Parameter #1305

Closed
zonky2 opened this issue Apr 29, 2019 · 4 comments
Closed

bug with pagination and filterreset - change GET to Slug-Parameter #1305

zonky2 opened this issue Apr 29, 2019 · 4 comments
Assignees
@zonky2
Labels
bug A bug! A bug! Fast, squish it!
Milestone
2.3.0

Comments

@zonky2
Copy link
Contributor

zonky2 commented Apr 29, 2019

we have pagination URL e.g. /de/pagination.html?page=2 and click the filter reset link, we change to /de/pagination/page/2.html ... but the next pagination link is /de/pagination/page/2.html?page=3 :(

current MM testcase
@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Apr 29, 2019
@zonky2 zonky2 added this to the 2.1.2 milestone Apr 29, 2019
@zonky2 zonky2 changed the title bug with pagination and filterreset - change GET to Slack-Parameter bug with pagination and filterreset - change GET to Slug-Parameter Apr 30, 2019
discordier added a commit that referenced this issue Apr 30, 2019
@discordier
Fix issue #1305 - pagination problem in clear all
60d8a46
@discordier discordier added the testing This ticket is reported to be fixed by a developer and should be tested. label Apr 30, 2019
@discordier discordier assigned zonky2 and unassigned discordier Apr 30, 2019
@zonky2 zonky2 removed the testing This ticket is reported to be fixed by a developer and should be tested. label May 1, 2019
@zonky2
Copy link
Contributor Author

zonky2 commented May 1, 2019

tested - works fine!

@zonky2 zonky2 closed this as completed May 1, 2019
@zonky2 zonky2 mentioned this issue May 1, 2019
Open
stefanheimes added a commit that referenced this issue May 16, 2019
@stefanheimes
Merge tag '2.1.2'
f7076c9 
Hotfix release 2.1.2

- Fix issue #1305 - Pagination problem in clear all.
- Increase length for legend titles.
- Rewrite SubSystemBoot as registered service.
- Hotfix translated section label: Expand database column to text.
- Hotfix for custom SQL filter: Fixed a problem where the access of the session inside of a custom SQL filter throws an exception.
- Updated translations from transifex.
@zonky2
Copy link
Contributor Author

zonky2 commented Jan 6, 2022

reopen for MM 2.2

@zonky2 zonky2 reopened this Jan 6, 2022
@zonky2 zonky2 modified the milestones: 2.1.2, 2.2.0 Jan 6, 2022
@zonky2
Copy link
Contributor Author

zonky2 commented May 5, 2022

see #890

@zonky2 zonky2 modified the milestones: 2.2.0, 2.3.0 May 8, 2022
@zonky2
Copy link
Contributor Author

zonky2 commented Mar 1, 2023

fixed in MM 2.3

@zonky2 zonky2 closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zonky2 zonky2

Labels
bug A bug! A bug! Fast, squish it!
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@discordier @zonky2