Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Update FixupUserGroupModules.php #1341

Merged
merged 2 commits into from Nov 4, 2019

Conversation

kampfq
Copy link
Contributor

@kampfq kampfq commented Oct 18, 2019

Description

fix Type error: Too few arguments to function tl_user_group::getModules(), 0 passed in /var/www/html/vendor/metamodels/core/src/CoreBundle/Contao/Hooks/FixupUserGroupModules.php on line 86 and exactly 1 expected

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

fix Type error: Too few arguments to function tl_user_group::getModules(), 0 passed in /var/www/html/vendor/metamodels/core/src/CoreBundle/Contao/Hooks/FixupUserGroupModules.php on line 86 and exactly 1 expected
@zonky2
Copy link
Contributor

zonky2 commented Oct 18, 2019

@kampfq pls check travis test https://travis-ci.org/MetaModels/core/jobs/599630774 and fix it - e.g. add @author...

@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Oct 18, 2019
@zonky2 zonky2 added this to the 2.1.6 milestone Oct 18, 2019
@zonky2
Copy link
Contributor

zonky2 commented Oct 18, 2019

1+

Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordier
Copy link
Member

Addendum, the problem was introduced in: contao/core-bundle@8286bf5#diff-82f57ce1482de14eccc165b0c67294b0L736-L737 and therefore affects Contao 4.8.4+ and 4.4.44+

@MacKP
Copy link
Contributor

MacKP commented Oct 28, 2019

Scheint zu funktionieren der Fix. Bitte übernehmen, damit auch alle was davon haben ;-)

@richardhj richardhj changed the title Update FixupUserGroupModules.php [RTM] Update FixupUserGroupModules.php Nov 1, 2019
stefanheimes added a commit that referenced this pull request Nov 4, 2019
- Update FixupUserGroupModules.php
- fix Type error: Too few arguments to function tl_user_group::getModules(), 0 passed in /var/www/html/vendor/metamodels/core/src/CoreBundle/Contao/Hooks/FixupUserGroupModules.php on line 86 and exactly 1 expected
@stefanheimes stefanheimes merged commit d48dbd1 into MetaModels:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug! A bug! Fast, squish it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants