Hotfix custom sql filter inserttags #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works with strung together as well as nested insert tags
rework identify inserttags in customSql Query
secure inserttags have more then two colons
|
@discordier workss fine for #880 (comment) a) and workaround) |
discordier
requested changes
Jan 25, 2023
src/Filter/Setting/CustomSql.php
Outdated
| * | ||
| * @return string | ||
| * | ||
| * @internal Only to be used via parseRequestVars(). | ||
| */ | ||
| public function convertParameter($arrMatch) | ||
| public function convertParameter($strMatch) |
There was a problem hiding this comment.
Can be made private now and the @internal can be removed. This method is now being called from $this->checkTag().
src/Filter/Setting/CustomSql.php
Outdated
| * | ||
| * @return string | ||
| * | ||
| * @internal Only to be used internal as callback from parseSecureInsertTags(). | ||
| */ | ||
| public function parseAndAddSecureInsertTagAsParameter($arrMatch) | ||
| public function parseAndAddSecureInsertTagAsParameter($strMatch) |
There was a problem hiding this comment.
Can be made private now and the @internal can be removed. This method is now being called from $this->checkTag().
discordier
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes the problem with strung together and nested inserttags
this should fix #880 (comment)
Checklist
@authorsin touched PHP files