New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM] Feature: searchable pages. #789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the options events for the filter field and the render setting field.
Add the basic class for adding all new pages for the search index and sidemaps.
Remove the $arrConfig variable and the initialization in the constructor. Remove the empty constructor, too.
Change the wrong call for $arrEnv to $this->arrEnv.
Add the tl_metamodel_searchable_pages to the list.
Remove the old subscriber and add one new with all functions.
Add a new subscriber for the searchable pages.
Remove the unused operation "settings" from the dca.
Rename fields in the DCA, database.sql and the language files.
- Utilize the serivce container. - Replace database lookup of filter parameters by retrieving the filter setting from the factory. - Remove the static function calls. - Add events for the filterparams property.
Change the dca_config and config.
- Make the functions smaller. - Utilize url generation. - Improve the handling with languages.
discordier
added
the
enhancement
This issue is about an enhancement (aka new feature)
label
Mar 27, 2015
- Add a better support for languages - Add a better support for url building. - Add a check for the rootpage.
Conflicts: src/MetaModels/Item.php
No the functions allow a jumpt to page with another language. For example: Tagert language is french the jump to page is a english page.
Hi ihr drei, wie geht es voran mit searchable_pages? |
@stefanheimes ready to merge? |
This was referenced Jul 11, 2015
Closed
Wollte mal fragen wie die Dinge stehen? LG |
Das kann aktuell nur @stefanheimes beantworten. |
With this new flag the function will create a url without a https.
The function will remove the https and the http from the current url list.
stefanheimes
changed the title
Feature: searchable pages.
Feature: searchable pages. [RTM]
Jul 23, 2015
+1 |
discordier
changed the title
Feature: searchable pages. [RTM]
[RTM] Feature: searchable pages.
Jul 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature to add MetaModel items "detail pages" to the searchable pages of Contao.