Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix für #944 Ansichtsbedingungen Attribut Eingabemaske #950

Closed
wants to merge 3 commits into from
Closed

Hotfix für #944 Ansichtsbedingungen Attribut Eingabemaske #950

wants to merge 3 commits into from

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Jan 8, 2016

No description provided.

@zonky2 zonky2 changed the title Hotfix für #944 Hotfix für #944 Ansichtsbedingungen Attribut Eingabemaske Jan 8, 2016

/**
* Fields
*/
$GLOBALS['TL_LANG']['tl_metamodel_dcasetting_condition']['type'] = array('Type', 'Select the attribute type.');
$GLOBALS['TL_LANG']['tl_metamodel_dcasetting_condition']['type'] = array('Type', 'Select the attribute or logic type.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select the condition type would be better here, wouldn't it?

@discordier
Copy link
Member

Aside from the mentioned notes on the language strings, it is good to merge.

@discordier discordier added the bug A bug! A bug! Fast, squish it! label Jan 8, 2016
@discordier discordier added this to the 2.0.0 milestone Jan 8, 2016
@discordier discordier self-assigned this Jan 8, 2016
@@ -296,6 +296,8 @@ protected function initializeWidget(&$arrField, $strRow, $strKey, $varValue)
$arrField['id'] = $this->strId . '_' . $strRow . '_' . $strKey;
$arrField['value'] = ($varValue !== '') ? $varValue : $arrField['default'];
$arrField['eval']['tableless'] = true;
$arrField['eval']['multiple'] = $arrField['inputType'] == 'select' ? true : false;
$arrField['eval']['chosen'] = $arrField['inputType'] == 'select' ? true : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong!

@zonky2
Copy link
Contributor Author

zonky2 commented Jan 11, 2016

die
src/MetaModels/Widgets/SubDcaWidget.php
gehört nicht dazu :-(

wie bekomme ich die aus dem PR wieder raus..?

@zonky2
Copy link
Contributor Author

zonky2 commented Jan 12, 2016

Geschlossen für neuen PR - bekomme src/MetaModels/Widgets/SubDcaWidget.php nicht entfernt...

Neu: #953

@zonky2 zonky2 closed this Jan 12, 2016
@zonky2 zonky2 deleted the Hotfix_Ansichtsbedingungen_Eingabemaske branch March 24, 2016 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug! A bug! Fast, squish it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants