[TM-6077] Re-Integrate Publishable Positions Edit #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott062
reviewed
Jun 4, 2024
Comment on lines
-165
to
+174
| 'PV_API_VERSION_I': '', | ||
| 'PV_AD_ID_I': '', | ||
| 'I_POS_SEQ_NUM': request.get('posSeqNum') or '', | ||
| 'I_PPOS_CAPSULE_DESCR_TXT': request.get('positionDetails') or '', | ||
| 'I_PPOS_LAST_UPDT_USER_ID': request.get('lastUpdatedUserID') or '', | ||
| 'I_PPOS_LAST_UPDT_TMSMP_DT': request.get('lastUpdated') or '', | ||
| 'pposposseqnum': request.get('posSeqNum') or '', | ||
| 'ppospubscd': request.get('psCD') or '', | ||
| 'pposaptsequencenum': request.get('aptSeqNum') or '', | ||
| 'pposcreatetmsmpdt': request.get('created') or '', | ||
| 'pposcreateuserid': request.get('createdUserID') or '', | ||
| 'pposcapsulemodifydt': request.get('positionDetailsLastUpdated') or '', | ||
| 'pposauditexclusionind': request.get('posAuditExclusionInd') or '', | ||
| 'pposcapsuledescrtxt': request.get('positionDetails') or '', | ||
| 'pposlastupdttmsmpdt': request.get('lastUpdated') or '', | ||
| 'pposlastupdtuserid': request.get('lastUpdatedUserID') or '', |
There was a problem hiding this comment.
Keep in mind that the original edit was only for capsule descriptions.
The new edit will encapsulate everything, but also means we have to consider how we want to break up the functionality. Should the API allow for all editing by anyone? How do we break out AOs editing everything, but bureaus/post only editing capsule? On FE only, API route protections, role checks inside the edit to determine if the field should be modifiable etc.?
We want to make sure the underlying service for edit PPOS can be vetted through our API based on the correct roles
cagbakwu
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Merge:
TM-6077