Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/delete outdated favorites v2 #367

Merged
merged 10 commits into from
Jun 9, 2020
Merged

Fix/delete outdated favorites v2 #367

merged 10 commits into from
Jun 9, 2020

Conversation

scott062
Copy link

  • Adds new archived field for pv/ap favorites (need to run migration)
  • Adds setting for favorites limit (50)
  • Sends 507 storage error response from views if user is above max limit
  • Triggers archive position function at favorites limit and half-point of limit for ap/pv

dual merge: MetaPhase-Consulting/State-TalentMAP#819

@scott062 scott062 mentioned this pull request May 28, 2020
Merged
@scott062 scott062 requested a review from mjoyce91 June 9, 2020 15:15
@scott062 scott062 merged commit f6ee947 into dev Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjoyce91 mjoyce91 mjoyce91 approved these changes

@elizabeth-jimenez elizabeth-jimenez Awaiting requested review from elizabeth-jimenez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@scott062 @mjoyce91