forked from USStateDept/State-TalentMAP-API
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating ab chart stats TM-2409 #654
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
c17672a
updating ab chart stats
SidelineCory24 48e86a8
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 cf13d0b
sorting grade & skill
SidelineCory24 082df98
adding OC Bureau to data structure
SidelineCory24 823656c
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 b46b772
Update available_bidders.py
SidelineCory24 9820d8c
updating comments
SidelineCory24 b424a4e
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 f2528b6
updating filter code
SidelineCory24 55796d7
cleaning up test
SidelineCory24 e0d7bcd
variable naming updates
SidelineCory24 3dfa9f8
code simplification
SidelineCory24 24a4f52
adding comment for 2+ post filtering
SidelineCory24 dcdb8a8
adding None data point into chart
SidelineCory24 de869cd
updating variable naming
SidelineCory24 6aead2a
updating data structure when stat returns None
SidelineCory24 734bce6
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 5bedeff
updating CDO None value to None listed
SidelineCory24 193a419
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 90054fc
handling edge case of showing no posts at all
SidelineCory24 4af22b2
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 229ee0a
Update available_bidders.py
SidelineCory24 941d47e
post not posts
SidelineCory24 3fa3564
updating variables
SidelineCory24 76aed83
updating none listed variable
SidelineCory24 f5365fb
removing instanceOf check
SidelineCory24 8678285
code simplification
SidelineCory24 d391a66
fixing none listed sum bug
SidelineCory24 32814c7
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 4ade1db
removing grade text
SidelineCory24 7f3882a
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 c218122
simplifying stat creation
SidelineCory24 96f7975
updating variable naming
SidelineCory24 eb3bd84
adding skill to stat creation function
SidelineCory24 9af955c
simplfying skill stat
SidelineCory24 7972cef
Merge branch 'dev' into update/available-bidders-chart-stats
mjoyce91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still duplicating a lot of the same code. For example, we always run
stats_sum[stat['statsKey']] += 1
regardless of which path the if/else takes, so why have that in both blocks?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplified skill code has been pushed