Fallback for homepage positions to use additional skill codes #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
requested review from
elizabeth-jimenez,
scott062 and
SidelineCory24
| @@ -633,4 +635,3 @@ export const HOME_PAGE_RECOMMENDED_POSITIONS = PropTypes.shape({ | |||
| positions: PropTypes.arrayOf(POSITION_DETAILS), | |||
| name: PropTypes.string, | |||
| }); | |||
|
|
|||
| FEATURED_GRADE_POSITIONS, | ||
| FEATURED_POSITIONS } from '../Constants/PropTypes'; | ||
|
|
||
| const specialNeedsParams = SPECIAL_NEEDS.join(','); | ||
|
|
||
| // Export our queries so that we can consistently test them. | ||
| export const GET_RECOMMENDED_GRADE_AND_SKILL_CODE_POSITIONS_QUERY = (skillCodes, grade) => `/fsbid/available_positions/?position__skill__code__in=${skillCodes}&position__grade__code__in=${grade}&limit=3`; | ||
| export const GET_RECOMMENDED_GRADE_AND_SKILL_CONE_POSITIONS_QUERY = (skillCodes, grade) => `/fsbid/available_positions/?position__skill__code__in=${skillCodes}&position__grade__code__in=${grade}&limit=3`; |
There was a problem hiding this comment.
I know technically this doesn't matter, but would it be better for readability to change these, and the ones on line 24&25, from skillCodes to skillCones?
There was a problem hiding this comment.
The naming was tricky because we're still technically sending in skillCodes, even though we're referring to it as skillCones. I think I'll leave it as is because of that.
| @@ -93,11 +102,13 @@ export function homePageFeaturedPositionsFetchData(skills = [], grade) { | |||
| .then((results) => { | |||
| let shouldSkip = false; | |||
| // if our query returned no results, we will want to fall to the next arrangement | |||
| if (isEmpty(results.data) && queryType.name !== 'featuredPositions') { | |||
| if (isEmpty(results.data) && queryType.name !== FEATURED_POSITIONS) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use with MetaPhase-Consulting/State-TalentMAP-API#417
Uses skill codes that fall in the skill cones of the user's skill codes as additional search criteria for homepage position fallbacks.