setting up FE for adding to available bidders and grabbing button state #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-jimenez
requested review from
mjoyce91,
scott062 and
SidelineCory24
mjoyce91
reviewed
Nov 24, 2020
mjoyce91
reviewed
Nov 25, 2020
|
I'm getting an error toast even though the PUT is successful
|
mjoyce91
reviewed
Nov 25, 2020
|
Make sure to run |
mjoyce91
reviewed
Nov 30, 2020
src/Components/BidderPortfolio/AddToInternalListButton/AddToInternalListButton.jsx
Outdated
Show resolved
Hide resolved
mjoyce91
reviewed
Nov 30, 2020
src/Components/BidderPortfolio/AddToInternalListButton/AddToInternalListButton.jsx
Outdated
Show resolved
Hide resolved
…etaPhase-Consulting/State-TalentMAP into feature/cdo-unassigned-bidders
mjoyce91
approved these changes
Dec 10, 2020
|
@mjoyce91 I added more stuff to it 😭 |
mjoyce91
reviewed
Dec 17, 2020
mjoyce91
reviewed
Dec 17, 2020
mjoyce91
reviewed
Dec 17, 2020
mjoyce91
reviewed
Dec 17, 2020
mjoyce91
reviewed
Dec 17, 2020
mjoyce91
reviewed
Dec 17, 2020
src/Components/BidderPortfolio/AddToInternalListButton/AddToInternalListButton.jsx
Outdated
Show resolved
Hide resolved
mjoyce91
reviewed
Dec 17, 2020
src/actions/cdo.js
Outdated
Comment on lines
135
to
146
| const config = { | ||
| method: remove ? 'delete' : 'put', | ||
| url: `cdo/${id}/availablebidders/`, | ||
| }; | ||
| const getAction = () => api()(config); | ||
|
|
||
| batch(() => { | ||
| dispatch(availableBiddersToggleUserIsLoading(true)); | ||
| dispatch(availableBiddersToggleUserErrored(false)); | ||
| }); | ||
|
|
||
| axios.all([getAction()]) |
There was a problem hiding this comment.
A little confused by this. axios.all is for when you have multiple requests. You should just be able to call api() directly
There was a problem hiding this comment.
if i remember correctly, i think just api()(config) was giving me trouble 🤔
There was a problem hiding this comment.
it worked this time! 👀 must have been something else wrong when i had api()(config) and i just assumed it was that 🤷♀️
mjoyce91
reviewed
Dec 17, 2020
src/Components/BidderPortfolio/AddToInternalListButton/AddToInternalListButton.jsx
Outdated
Show resolved
Hide resolved
mjoyce91
reviewed
Dec 18, 2020
src/actions/cdo.js
Outdated
Comment on lines
146
to
145
| axios.all([getAction()]) | ||
| api()(config) |
There was a problem hiding this comment.
yes :) i commented above 👍
mjoyce91
reviewed
Dec 18, 2020
| .then(() => { | ||
| const toastTitle = remove ? REMOVE_FROM_INTERNAL_LIST_SUCCESS_TITLE | ||
| : ADD_TO_INTERNAL_LIST_SUCCESS_TITLE; | ||
| // TODO: update this path during integration of Available Bidders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Merge: API PR 445
Ticket text 'Add to Internal List' and 'Remove from Internal List' too lengthy; 'Add' and 'Remove' replaced with icons