Organization filter on bureau positions page #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
requested review from
elizabeth-jimenez,
scott062 and
SidelineCory24
Comment on lines
-19
to
-21
| import ListItem from '../../BidderPortfolio/BidControls/BidCyclePicker/ListItem'; | ||
| import { filtersFetchData } from '../../../actions/filters/filters'; | ||
| import SelectForm from '../../SelectForm'; |
| <Flag | ||
| name="flags.static_content" | ||
| render={() => ( | ||
| /* eslint-disable-next-line no-nested-ternary */ |
| <div className="filter-div"> | ||
| <div className="label">Organization:</div> | ||
| <Picky | ||
| placeholder="Select Bureau(s)" |
There was a problem hiding this comment.
placeholder Select Organization(s)
Comment on lines
+130
to
+132
| if (!noBureausSelected || !noOrgsSelected) { | ||
| props.fetchBureauPositions(query); | ||
| } |
| @@ -386,7 +423,7 @@ const PositionManager = props => { | |||
| <ExportButton | |||
| onClick={exportPositions} | |||
| isLoading={isLoading} | |||
| disabled={noBureausSelected} | |||
| disabled={noBureausSelected && noOrgsSelected} | |||
There was a problem hiding this comment.
Nit Picky: we hide all filters and Export Button when overlay triggered, so we don't really need to disable it, but unsure if this way is a better practice.
There was a problem hiding this comment.
Ah good point. Yeah, maybe we just keep this in case we decide to show them in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post_uservsbureau_userStaticDevContent