updating ab chart stats TM-2409 #1909
Conversation
…aPhase-Consulting/State-TalentMap into update/available-bidders-chart-stats
SidelineCory24
changed the title
SidelineCory24
requested review from
elizabeth-jimenez,
mjoyce91 and
scott062
|
@mjoyce91 when I click the "details" link for the |
…aPhase-Consulting/State-TalentMap into update/available-bidders-chart-stats
src/Components/AvailableBidder/AvailableBidderStats/AvailableBidderStats.jsx
Outdated
Show resolved
Hide resolved
@SidelineCory24 - just add an |
src/Components/AvailableBidder/AvailableBidderStats/AvailableBidderStats.jsx
Outdated
Show resolved
Hide resolved
|
Seeing some weird behavior on the percentages for these
|
handling on BE |
| const stats = get(biddersData, 'stats', {})[selectedStat] || []; | ||
| const statsSum = get(biddersData, 'stats.Sum', {})[selectedStat] || 0; |
|
FE looks good, can approve once also working with back-end |
Good catch! |
|
|
this has been fixed on the BE |
…aPhase-Consulting/State-TalentMap into update/available-bidders-chart-stats
|
| const grades$ = grades.map(grade => ({ ...grade, code: grade.name })); | ||
| grades$.sort(sortGrades); | ||
|
|
||
| const stat = selectedStat === 'Grade' ? grades$ : stats; | ||
|
|
There was a problem hiding this comment.
This may be cleaner, and easier to understand that stats are the statistics for a single section (opposed to all)
if (selectedStat === 'Grade') {
stats = stats.map(grade => ({ ...grade, code: grade.name }));
stats.sort(sortGrades);
}
@mjoyce91 or is modifying stats a big no-no?
…aPhase-Consulting/State-TalentMap into update/available-bidders-chart-stats
|
|
||
| // sorting grades to maintain consistency across the site | ||
| if (selectedStat === 'Grade') { | ||
| stats = stats.map(grade => ({ ...grade, code: grade.name })); |
There was a problem hiding this comment.
Nice job on making this an implicit return 🦜
BE PR
To-Do