Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ab chart stats TM-2409 #1909

Merged
merged 35 commits into from
Jan 21, 2022
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
d924a68
updating ab chart stats
SidelineCory24 Jan 6, 2022
888458a
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 6, 2022
c86eb13
bold percentages for grade & skill
SidelineCory24 Jan 7, 2022
182e925
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 Jan 7, 2022
8e64990
adding OC Bureau
SidelineCory24 Jan 11, 2022
9774600
adding comments
SidelineCory24 Jan 11, 2022
61125b1
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 11, 2022
b2bbded
Update AvailableBidderStats.jsx
SidelineCory24 Jan 11, 2022
2e3d065
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 11, 2022
df7e512
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 12, 2022
6069fd7
removing comment
SidelineCory24 Jan 12, 2022
240c0b7
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 Jan 12, 2022
1ada685
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 14, 2022
19a5b5f
ab stats test
SidelineCory24 Jan 14, 2022
eb21929
adding lodash includes for perecent styling
SidelineCory24 Jan 14, 2022
9cbae29
bolding all percentage values
SidelineCory24 Jan 14, 2022
4a80705
test update
SidelineCory24 Jan 14, 2022
4ef70af
Update AvailableBiddersStats.test.jsx
SidelineCory24 Jan 14, 2022
95af851
test updates
SidelineCory24 Jan 14, 2022
21d22b9
test update
SidelineCory24 Jan 18, 2022
40515d4
more test updates
SidelineCory24 Jan 18, 2022
f7a3988
testing updates again, gettig expected values to match
SidelineCory24 Jan 18, 2022
749471b
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 18, 2022
bd7a8e9
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 18, 2022
15f559c
Merge branch 'dev' into update/available-bidders-chart-stats
elizabeth-jimenez Jan 18, 2022
74c413d
Merge branch 'dev' into update/available-bidders-chart-stats
elizabeth-jimenez Jan 18, 2022
a678fe8
Merge branch 'dev' into update/available-bidders-chart-stats
mjoyce91 Jan 19, 2022
4419029
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 19, 2022
1eb0e2d
ordering grade properly
SidelineCory24 Jan 19, 2022
0392a93
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 Jan 19, 2022
049385b
Merge branch 'dev' into update/available-bidders-chart-stats
mjoyce91 Jan 20, 2022
5daa884
simplifying grade sorting
SidelineCory24 Jan 20, 2022
ba0b9f8
Merge branch 'update/available-bidders-chart-stats' of github.com:Met…
SidelineCory24 Jan 20, 2022
442394d
Merge branch 'dev' into update/available-bidders-chart-stats
mjoyce91 Jan 20, 2022
ec797ea
Merge branch 'dev' into update/available-bidders-chart-stats
SidelineCory24 Jan 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import FA from 'react-fontawesome';
import { Cell, Pie, PieChart, Tooltip } from 'recharts';
import InteractiveElement from 'Components/InteractiveElement';
import LoadingText from 'Components/LoadingText';
import { getAvatarColor } from 'utilities';
import { getAvatarColor, sortGrades } from 'utilities';
import Picky from 'react-picky';
import { Row } from '../../Layout';

Expand All @@ -15,19 +15,26 @@ const AvailableBidderStats = () => {

const statOptions = [
'Bureau',
'CDO',
'Grade',
'OC Bureau',
'Post',
'Skill',
'Status',
'TED',
];

// App state
const biddersData = useSelector(state => state.availableBiddersFetchDataSuccess);
const availableBiddersIsLoading = useSelector(state => state.availableBiddersFetchDataLoading);

const stats = get(biddersData.stats, selectedStat) || [];
const statsSum = get(biddersData.stats, 'Sum', {})[selectedStat];
let stats = get(biddersData, 'stats', {})[selectedStat] || [];
const statsSum = get(biddersData, 'stats.Sum', {})[selectedStat] || 0;

// sorting grades to maintain consistency across the site
if (selectedStat === 'Grade') {
stats = stats.map(grade => ({ ...grade, code: grade.name }));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on making this an implicit return 🦜

stats.sort(sortGrades);
}

// adding colors
const stats$ = stats.map(m => {
Expand Down Expand Up @@ -92,7 +99,12 @@ const AvailableBidderStats = () => {
className="legend-square"
style={{ backgroundColor: m.color }}
/>
<div className="legend-text">{`(${m.value}) ${m.name} ${m.percent}`}</div>
<div className="legend-text">
{`(${m.value}) ${m.name}`}
<span className="percent-text">
{`${m.percent}`}
</span>
</div>
</div>
))
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import TestUtils from 'react-dom/test-utils';
import { Provider } from 'react-redux';
import { MemoryRouter } from 'react-router-dom';
import configureStore from 'redux-mock-store';
import thunk from 'redux-thunk';
import AvailableBidderStats from './AvailableBidderStats';

const middlewares = [thunk];
const mockStore = configureStore(middlewares);

describe('AvailableBidderStats', () => {
it('is defined', () => {
const wrapper = TestUtils.renderIntoDocument(<Provider store={mockStore({})}><MemoryRouter>
<AvailableBidderStats isCDO />
</MemoryRouter></Provider>);
expect(wrapper).toBeDefined();
});
});
5 changes: 5 additions & 0 deletions src/sass/_availableBidders.scss
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@
margin: auto .8em;
}

.percent-text {
font-weight: bold;
margin-left: .4em;
}

.chart-container {
margin-right: auto;

Expand Down