Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alert on potential session expire #1912

Merged
merged 9 commits into from
Jan 19, 2022
Merged

Show alert on potential session expire #1912

merged 9 commits into from
Jan 19, 2022

Conversation

mjoyce91
Copy link

@mjoyce91 mjoyce91 commented Jan 7, 2022

Show an alert when all of the following occur at once:

  • The user is using Go Browser
  • The session has been active for at least 1 hour
  • An undefined type axios network failure has occurred
  • The alert has not already been displayed

One way to test this:

  • Change isOnProxy function to check for "localhost" insteadof "msappproxy"
  • Decrease timeout time from hoursToMilliseconds(1) to a shorter wait time
  • Try to perform a network request with Offline network simulated in Chrome

@scott062
Copy link

Following your testing instructions, I was able to see the alert and close it etc. When you navigate to another page, the alert doesn't reappear if its already been "closed" once. Do we want it to re-appear on page change despite them having closed it already?

@mjoyce91
Copy link
Author

Following your testing instructions, I was able to see the alert and close it etc. When you navigate to another page, the alert doesn't reappear if its already been "closed" once. Do we want it to re-appear on page change despite them having closed it already?

@scott062 - that was something I thought about. I wanted it to be as unobtrusive as possible, at least since I'm forcing them to manually close it in the first place.

Copy link

@scott062 scott062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to approve

@mjoyce91 mjoyce91 merged commit 5b91f6a into dev Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants