Full page for notifications #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtirserio
approved these changes
Jun 11, 2019
* dev: Update config_dev.json Wrap PV network requests in feature flag Make search input label consistent across home page and results page Add Administrator page, ability to download log file Add loading state to search filters Differentiate between full bidding that will eventually be handled by TalentMAP, versus what will be available in FSBid; set this in a feature flag # Conflicts: # src/Components/ProfilePage/ProfilePage.jsx # src/Components/ProfilePage/__snapshots__/ProfilePage.test.jsx.snap # src/sass/styles.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes most of TM-922 by adding a dedicated Notifications page.
Does not include batch actions, as that should probably be handled by a new API endpoint (opposed to creating unique HTTP calls for each notificationid).Edit: Ended up including batch actions. May still want to revisit that from an API side if we want to perform batch actions across a user's entire notification list, without going through them page by page on the UI.