-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update profile page based on qa #36
Conversation
<div className="condensed-card-bottom-container"> | ||
<div className="usa-grid-full condensed-card-bottom"> | ||
<CondensedCardData position={position} /> | ||
<div className="usa-grid-full condensed-card-buttons-section"> | ||
<Favorite | ||
hideText | ||
useLongText | ||
hasBorder | ||
refKey={position.id} | ||
compareArray={favorites} | ||
useButtonClass | ||
useButtonClassSecondary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe in @cydneycappello 's designs, the button is blue, so you can remove the useButtonClassSecondary
prop here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment about button color.
Resolves TM-306