-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16 #512
React 16 #512
Conversation
We'll have to refactor most of our functional components: https://airbnb.io/enzyme/docs/api/ShallowWrapper/props.html#example See dd68b42 for an example - we no longer have access to unused props, but we can check props on the root element. |
@@ -35,6 +36,8 @@ class Editor extends Component { | |||
submitProps={{ id: SUBMIT_BUTTON_ID }} | |||
/> | |||
<div className="usa-grid-full markdown-editor"> | |||
{ | |||
/* | |||
<MarkdownEditor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even https://github.com/jrm2k6/react-markdown-editor/tree/1.0.0 breaks, so we'll need to look into replacing this library
Just needed to remove the styles.
@@ -12,7 +12,7 @@ import FA from 'react-fontawesome'; | |||
import { addHours, format, parse, subHours } from 'date-fns'; | |||
import DayPickerInput from 'react-day-picker/DayPickerInput'; | |||
import { DateUtils } from 'react-day-picker'; | |||
import TimeInput from 'time-input'; | |||
// import TimeInput from 'time-input'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library is no longer maintained, but this looks straight forward to fork into our repo
https://github.com/alanclarke/time-input/blob/master/src/TimeInput.js#L13
This fork is React 16 compatible - https://github.com/radumardale/react-keyboard-time-input
@@ -15,11 +15,13 @@ exports[`Alert displays error alert with multiple messages 1`] = ` | |||
</h3> | |||
<p | |||
className="usa-alert-text" | |||
key="ZG9_0yeXR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to ignore or mock Doneshortid
keys
From https://github.com/cerner/terra-core/wiki/React-16-Migration-Guide#noted-changes
See 8d2abaa |
… by moving styles from component to css # Trying to use built-in style prop with this component results in a error that breaks the site
…ble with React 16
Optional upgrades: react-countup - breaks at 4.2.2, probably just new syntax/config |
history: PropTypes.shape({}).isRequired, | ||
history: PropTypes.shape({ | ||
listen: PropTypes.func, | ||
location: PropTypes.object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use shape
instead of object
@@ -44,7 +44,7 @@ | |||
"indent": ["error", 2, { "ignoredNodes": ["JSXAttribute", "JSXSpreadAttribute"], "SwitchCase": 1 }], | |||
"react/jsx-indent": [0], | |||
"react/jsx-indent-props": ["error", 2], | |||
"complexity": ["warn", { "max": 20 }], | |||
"complexity": ["warn", { "max": 30 }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3️⃣ 0️⃣
@@ -94,7 +94,7 @@ ResultsCondensedCardBottom.contextTypes = { | |||
}; | |||
|
|||
ResultsCondensedCardBottom.propTypes = { | |||
position: POSITION_DETAILS.isRequired, | |||
position: PropTypes.oneOf([POSITION_DETAILS, { position: POSITION_DETAILS }]).isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ones like this will actually need to be oneOfType
. I'll fix
Thanks @scott062 ! Looks good |
* dev: Bump helmet from 3.21.2 to 3.21.3 Update test since this reducer now spreads Use new dedicated routes to get just the IDs of favorite positions; don't refetch all userProfile data on favorite add/delete Remove uneccessary styling Fix it for real Fix css scope Media query nested to test for ie11 Fix flex-basis and min-width 4 -> 3 Disable runInBand but limit maxWorkers to 4
…te-TalentMAP into update/react-16 * 'update/react-16' of github.com:MetaPhase-Consulting/State-TalentMAP: Get default sort value from Constants/Sort fix: default sorting for client list to last_name
@rtirserio @scott062 @elizabeth-jimenez - can you review this? You don't need to go through all 5,000 lines - mainly concerned with functionality and local dev environments. Also, not concerned about warning logs (mainly around lifecycle methods) right now. You'll need to:
|
* dev: Update snapshots Add select all field to cdo search
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked basic bidder functionality
Checked basic CDO functionality
Checked admin functionality
👍 Looks great
No description provided.