Update/bid tracker remaining bids message #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
reviewed
Feb 24, 2020
| @@ -62,16 +62,16 @@ class BidTracker extends Component { | |||
| render() { | |||
There was a problem hiding this comment.
I'm trying to tell - was anything actually updated in this file, or did the line spacing just change?
There was a problem hiding this comment.
In the end, after being further explained the intention of the ticket, no. Before, when I added a whole alert and was counting approved bids and non-approved, yes. I guess when I removed the unnecessary code, the spacing updated.
There was a problem hiding this comment.
Cool, see if you can revert the changes so that the spacing is back to normal
mjoyce91
reviewed
Feb 24, 2020
| {title} has been filled | ||
| Your bid on {title} is no longer applicable. |
…taPhase-Consulting/State-TalentMAP into update/bidTrackerRemainingBidsMessage merging with dev
mjoyce91
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will discuss at Retro. Not sure if this is what was agreed upon.