forked from USStateDept/State-TalentMAP
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/bid tracker remaining bids message #715
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e6ec6ca
alert message added for approved bid
elizabeth-jimenez d3c5b81
updated tests
elizabeth-jimenez 81413ec
updated text in Closed alert. Tests updated.
elizabeth-jimenez fcdc1d7
Merge branch 'dev' into update/bidTrackerRemainingBidsMessage
elizabeth-jimenez 6709f47
Merge branch 'dev' into update/bidTrackerRemainingBidsMessage
elizabeth-jimenez e1afd7a
spacing in file updated
elizabeth-jimenez 2f35ee6
Merge branch 'dev' into update/bidTrackerRemainingBidsMessage
elizabeth-jimenez 4acb6de
Merge branch 'update/bidTrackerRemainingBidsMessage' of github.com:Me…
elizabeth-jimenez 5a15a8a
Merge branch 'dev' into update/bidTrackerRemainingBidsMessage
mjoyce91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ import LinkButton from '../../../LinkButton'; | |
const ClosedAlert = ({ title, date, id }, { condensedView }) => ( | ||
<div className="bid-tracker-alert-container bid-tracker-alert-container--closed"> | ||
<div className="top-text"> | ||
{title} has been filled | ||
Your bid on {title} is no longer applicable. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
</div> | ||
{ | ||
date && | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to tell - was anything actually updated in this file, or did the line spacing just change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end, after being further explained the intention of the ticket, no. Before, when I added a whole alert and was counting approved bids and non-approved, yes. I guess when I removed the unnecessary code, the spacing updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, see if you can revert the changes so that the spacing is back to normal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll try