Feature/favorite max notification TM-1618 #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: deleted duplicate branch that I had unnecessarily branched off of Elizabeth's pagination PR |
mjoyce91
reviewed
Mar 31, 2020
src/Constants/SystemMessages.js
Outdated
| @@ -51,6 +51,7 @@ export const DELETE_FAVORITE_SUCCESS = (pos, onToggle) => RemoveSuccess({ pos, o | |||
| export const DELETE_FAVORITE_ERROR = () => "We're experiencing an error attempting to remove this position from your Favorites. Please try again."; | |||
| export const ADD_FAVORITE_SUCCESS = pos => FavoriteSuccess({ pos }); | |||
| export const ADD_FAVORITE_ERROR = () => "We're experiencing an error attempting to add this position to your Favorites. Please try again."; | |||
| export const ADD_FAVORITE_LIMIT_ERROR = 'You have reached the favorites limit of 250. Please remove a favorite and try again.'; | |||
There was a problem hiding this comment.
Can we have the API own and send back the limit number? Then the front-end doesn't need to be a source of truth and would reduce any back and forth changes should we decide to change the limit.
|
Discussed in Slack, just putting here for consistency: Custom Toast notification for AP vs PV. Ex: You have reached favorites limit of 250 for Open Positions. Please remove an Open Positions favorite and try again. |
…MetaPhase-Consulting/State-TalentMAP into feature/favoriteMaxNotification
mjoyce91
reviewed
Apr 2, 2020
src/actions/userProfile.js
Outdated
Comment on lines
233
to
241
| if (remove) { | ||
| message = SystemMessages.DELETE_FAVORITE_ERROR(); | ||
| } else if (response.status === 507 && isPV) { | ||
| message = SystemMessages.ADD_FAVORITE_LIMIT_ERROR_PV(limit); | ||
| } else if (response.status === 507) { | ||
| message = SystemMessages.ADD_FAVORITE_LIMIT_ERROR_AP(limit); | ||
| } else { | ||
| message = SystemMessages.ADD_FAVORITE_ERROR(); | ||
| } |
mjoyce91
reviewed
Apr 2, 2020
mjoyce91
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: MetaPhase-Consulting/State-TalentMAP-API#367