Use internal/external OBC URL #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,28 +24,32 @@ const OBCUrl = ({ type, label, isButton, altStyle, url }) => { | |||
|
|
|||
| text = label || `${text} details`; | |||
There was a problem hiding this comment.
Do you think we should capitalize 'details' to stay more consistent (sometimes we send in label as 'myTxt Details')?
There was a problem hiding this comment.
I think there's a reason we use one over the other (when this appears in the results card vs details page, etc)
src/Components/OBCUrl/OBCUrl.jsx
Outdated
| @@ -22,28 +24,32 @@ const OBCUrl = ({ type, label, isButton, altStyle, url }) => { | |||
|
|
|||
| text = label || `${text} details`; | |||
|
|
|||
| if (includes(get(window, 'location.host'), 'msappproxy')) { | |||
| url$ = url.external; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the external version of the OBC URL on the proxy.
Easiest way to test is to change
'msappproxy'to'localhost'.Use with MetaPhase-Consulting/State-TalentMAP-API#370