-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal/external OBC URL #939
Conversation
@@ -22,28 +24,32 @@ const OBCUrl = ({ type, label, isButton, altStyle, url }) => { | |||
|
|||
text = label || `${text} details`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should capitalize 'details' to stay more consistent (sometimes we send in label as 'myTxt Details')?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a reason we use one over the other (when this appears in the results card vs details page, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, gotcha 👍 good to know :)
src/Components/OBCUrl/OBCUrl.jsx
Outdated
@@ -22,28 +24,32 @@ const OBCUrl = ({ type, label, isButton, altStyle, url }) => { | |||
|
|||
text = label || `${text} details`; | |||
|
|||
if (includes(get(window, 'location.host'), 'msappproxy')) { | |||
url$ = url.external; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 No Lodash get
? 😱 🙀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍨 🍬 🍭 🍰 👍
Display the external version of the OBC URL on the proxy.
Easiest way to test is to change
'msappproxy'
to'localhost'
.Use with MetaPhase-Consulting/State-TalentMAP-API#370