Compare Page QA #94
Merged
Compare Page QA #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o comparisons, use Set() for bidListToggleIsLoading
rtirserio
suggested changes
Mar 4, 2019
|
Updated |
rtirserio
approved these changes
Mar 6, 2019
|
@rtirserio I think that happens everywhere with the Favorites right now, since we're only storing the most recent loading state. I could migrate it to work like the Bid List loading state, how I started tracking the IDs of ones that are currently loading. I've created TM-587 to come back to this. I'll merge for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete TM-542 by breaking out some of the comparison elements into their rows and adding the Bid List button to the Comparison items. Change bidListToggleIsLoading to a
Set()so that we can track when multiple IDs are loading.Relies on API change MetaPhase-Consulting/State-TalentMAP-API#32Merged