-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare Page QA #94
Compare Page QA #94
Conversation
…o comparisons, use Set() for bidListToggleIsLoading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw some errors that looked like this when I went to the position details page...
Warning: Failed prop type: Invalid prop `bidListToggleIsLoading` of type `object` supplied to `PositionTitle`, expected `boolean`.
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing a little bit of weirdness with the buttons when you click on a few of them quickly. the loading seems to disappear and after a slight delay the button changes to the correct text. Nothing that should keep this from getting merged
@rtirserio I think that happens everywhere with the Favorites right now, since we're only storing the most recent loading state. I could migrate it to work like the Bid List loading state, how I started tracking the IDs of ones that are currently loading. I've created TM-587 to come back to this. I'll merge for now. |
Complete TM-542 by breaking out some of the comparison elements into their rows and adding the Bid List button to the Comparison items. Change bidListToggleIsLoading to a
Set()
so that we can track when multiple IDs are loading.Relies on API change MetaPhase-Consulting/State-TalentMAP-API#32Merged