Feature/bureau position results card #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
commented
Jul 19, 2020
Comment on lines
73
to
101
| <Row fluid className="bureau-results-card"> | ||
| <Row fluid> | ||
| <Row fluid style={{ display: 'flex' }} className="bureau-card--header"> | ||
| <div>{detailsLink}</div> | ||
| <div>{postShort}</div> | ||
| {renderBidCountMobile(stats)} | ||
| </Row> | ||
| <Row fluid style={{ display: 'flex' }} className="bureau-card--content"> | ||
| <DefinitionList itemProps={{ excludeColon: true }} items={sections[0]} style={{ display: 'flex' }} className="bureau-definition" /> | ||
| </Row> | ||
| <Row fluid style={{ display: 'flex' }} className="bureau-card--footer"> | ||
| <DefinitionList items={sections[1]} style={{ display: 'flex' }} /> | ||
| <div className="usa-grid-full" style={{ position: 'relative' }}> | ||
| <InteractiveElement onClick={() => this.setState({ showMore: !showMore })} style={{ bottom: 0, position: 'absolute', right: 0 }}> | ||
| <span style={{ whiteSpace: 'nowrap' }}>View {showMore ? 'less' : 'more'} </span> | ||
| <FA name={`chevron-${showMore ? 'up' : 'down'}`} /> | ||
| </InteractiveElement> | ||
| </div> | ||
| </Row> | ||
| </Row> | ||
| { | ||
| showMore && | ||
| <Row fluid style={{ marginTop: '1em' }}> | ||
| <Linkify properties={{ target: '_blank' }}> | ||
| {description} | ||
| </Linkify> | ||
| </Row> | ||
| } | ||
| </Row> |
There was a problem hiding this comment.
I need to clean up the inline styles here before merging
elizabeth-jimenez
approved these changes
Jul 20, 2020
| describe('BureauPage', () => { | ||
| it('mounts', () => { |
| @@ -1,23 +1,8 @@ | |||
| import React from 'react'; | |||
| import { shallow } from 'enzyme'; | |||
| import TestUtils from 'react-dom/test-utils'; | |||
| import { Row } from 'Components/Layout'; | ||
| import DefinitionList from 'Components/DefinitionList'; | ||
| import InteractiveElement from 'Components/InteractiveElement'; | ||
| import { getResult, getBidStatsToUse, getDifferentials, renderBidCountMobile } from 'Components/ResultsCard/ResultsCard'; |
There was a problem hiding this comment.
😎
Don't think i've ever seen this used like this before. Very cool 🏅
There was a problem hiding this comment.
Yeah, we already had that logic built out in the ResultsCard component, so instead of re-creating or moving it to utilities, I just exported those functions.
There was a problem hiding this comment.
I'll keep that in mind, as we build out other Bureau stuff 🆒
| @@ -22,6 +23,11 @@ const Stats = (props) => { | |||
| <div className="usa-grid-full bureau-page"> | |||
| {placeholderText} | |||
| </div> | |||
| <div className="usa-grid-full"> | |||
| {[1, 2, 3, 4, 5].map((m) => ( | |||
| import PropTypes from 'prop-types'; | ||
| import { get } from 'lodash'; | ||
| import FA from 'react-fontawesome'; | ||
| import Linkify from 'react-linkify'; |
| import React, { Component } from 'react'; | ||
| import { Link } from 'react-router-dom'; | ||
| import PropTypes from 'prop-types'; | ||
| import { get } from 'lodash'; |
There was a problem hiding this comment.
only 1 for lodash? I'm disappointed....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1006
Adds static position results card to be integrated in the future. Placed it on the Bureau Stats page for now.