Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position Manager filters TM-1860 #1013

Merged
merged 12 commits into from
Jul 22, 2020
Merged

Conversation

elizabeth-jimenez
Copy link

@elizabeth-jimenez elizabeth-jimenez commented Jul 17, 2020

Just dummy filters with dummy data; may want to update to use real data? "real" as in, import all the grades or skills, etc

Pause Merge

@elizabeth-jimenez elizabeth-jimenez added WIP Work in progress and removed pause merge labels Jul 20, 2020
@elizabeth-jimenez
Copy link
Author

WIP tag added, going to update dropdowns to be Picky

@mjoyce91
Copy link

This looks really good! I know you're looking into moving to picky, but one thing I noticed was the vertical spacing for the dropdown labels (i.e., bring them down a little so that they're centered with the dropdown)

Screen Shot 2020-07-21 at 1 31 00 PM

@mjoyce91
Copy link

Shadow probably shouldn't "shine" up into the header like this:

Screen Shot 2020-07-21 at 1 34 24 PM

@elizabeth-jimenez
Copy link
Author

This looks really good! I know you're looking into moving to picky, but one thing I noticed was the vertical spacing for the dropdown labels (i.e., bring them down a little so that they're centered with the dropdown)

Screen Shot 2020-07-21 at 1 31 00 PM

Thanks! When i convert to picky i'll likely have to update most of the styles 😭 I'll be sure to make sure the labels are centered 😄 🔎 🕵️‍♂️

@elizabeth-jimenez
Copy link
Author

Shadow probably shouldn't "shine" up into the header like this:

Screen Shot 2020-07-21 at 1 34 24 PM

🕵️‍♂️ ooo good catch! I couldn't see it cause it kinda blended into the gold banner.

@elizabeth-jimenez elizabeth-jimenez removed the WIP Work in progress label Jul 21, 2020
Copy link

@mjoyce91 mjoyce91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mjoyce91 mjoyce91 merged commit 923fb80 into dev Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants