Persist saved search sort option after a deletion; fix Nav spacing

src/Components/SavedSearches/SavedSearches.jsx

@@ -53,11 +53,11 @@ const SavedSearches = props => {
   const isLoading = (filtersIsLoading || savedSearchesIsLoading);
 
   const options = [
-    { title: 'All Saved Searches', value: 'all', numerator: getSearches('all').length },
-    { title: 'Open Positions', value: 'open', numerator: getSearches('open').length },
-    { title: 'Projected Vacancies', value: 'pv', numerator: getSearches('pv').length },
-    { title: 'Tandem Open Positions', value: 'open-ts', numerator: getSearches('open-ts').length },
-    { title: 'Tandem Projected Vacancies', value: 'pv-ts', numerator: getSearches('pv-ts').length },
+    { title: 'All Saved Searches ', value: 'all', numerator: getSearches('all').length },
+    { title: 'Open Positions ', value: 'open', numerator: getSearches('open').length },
+    { title: 'Projected Vacancies ', value: 'pv', numerator: getSearches('pv').length },
+    { title: 'Tandem Open Positions ', value: 'open-ts', numerator: getSearches('open-ts').length },
+    { title: 'Tandem Projected Vacancies ', value: 'pv-ts', numerator: getSearches('pv-ts').length },
   ];
 
   const searches = { results: getSearches() };

src/Components/SavedSearches/__snapshots__/SavedSearches.test.jsx.snap

@@ -57,27 +57,27 @@ exports[`SavedSearchesComponent matches snapshot 1`] = `
       Array [
         Object {
           "numerator": 1,
-          "title": "All Saved Searches",
+          "title": "All Saved Searches ",
           "value": "all",
         },
         Object {
           "numerator": 1,
-          "title": "Open Positions",
+          "title": "Open Positions ",
           "value": "open",
         },
         Object {
           "numerator": 0,
-          "title": "Projected Vacancies",
+          "title": "Projected Vacancies ",
           "value": "pv",
         },
         Object {
           "numerator": 0,
-          "title": "Tandem Open Positions",
+          "title": "Tandem Open Positions ",
           "value": "open-ts",
         },
         Object {
           "numerator": 0,
-          "title": "Tandem Projected Vacancies",
+          "title": "Tandem Projected Vacancies ",
           "value": "pv-ts",
         },
       ]

src/Containers/SavedSearches/SavedSearches.jsx

@@ -3,22 +3,36 @@ import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
 import { withRouter } from 'react-router';
 import { push } from 'connected-react-router';
-import { savedSearchesFetchData, setCurrentSavedSearch, deleteSavedSearch } from '../../actions/savedSearch';
-import { SAVED_SEARCH_PARENT_OBJECT } from '../../Constants/PropTypes';
-import { DEFAULT_USER_PROFILE, POSITION_RESULTS_OBJECT } from '../../Constants/DefaultProps';
+import { isEqual } from 'lodash';
+import { savedSearchesFetchData, setCurrentSavedSearch, deleteSavedSearch } from 'actions/savedSearch';
+import { SAVED_SEARCH_PARENT_OBJECT } from 'Constants/PropTypes';
+import { DEFAULT_USER_PROFILE, POSITION_RESULTS_OBJECT } from 'Constants/DefaultProps';
+import { formQueryString } from 'utilities';
 import SavedSearchesMap from '../SavedSearchesMap';
-import { formQueryString } from '../../utilities';
 
 // Wrapper for anything related to saved searches
 // Make sure to update Components/ResultsMultiSearchHeader/bypassRoutes.js with any routes
 // that use this container.
 class SavedSearchesContainer extends Component {
+  constructor(props) {
+    super(props);
+    this.state = {
+      defaultSort: '',
+    };
+  }
+
   UNSAFE_componentWillMount() {
     this.getSavedSearches();
   }
 
+  componentWillReceiveProps(nextProps) {
+    if (!isEqual(nextProps.deleteIsLoading, this.props.deleteIsLoading)) {
+      this.getSavedSearches();
+    }
+  }
+
   getSavedSearches() {
-    this.props.savedSearchesFetchData();
+    this.props.savedSearchesFetchData(this.state.defaultSort);
   }
 
   getSortedSearches = type => {
@@ -62,6 +76,7 @@ SavedSearchesContainer.propTypes = {
   savedSearchesIsLoading: PropTypes.bool.isRequired,
   setCurrentSavedSearch: PropTypes.func.isRequired,
   deleteSearch: PropTypes.func.isRequired,
+  deleteIsLoading: PropTypes.bool,
   ChildElement: PropTypes.func.isRequired,
 };
 
@@ -71,6 +86,7 @@ SavedSearchesContainer.defaultProps = {
   savedSearches: POSITION_RESULTS_OBJECT,
   savedSearchesIsLoading: true,
   savedSearchesHasErrored: false,
+  deleteIsLoading: false,
 };
 
 SavedSearchesContainer.contextTypes = {
@@ -83,6 +99,7 @@ const mapStateToProps = (state, ownProps) => ({
   savedSearches: state.savedSearchesSuccess,
   savedSearchesIsLoading: state.savedSearchesIsLoading,
   savedSearchesHasErrored: state.savedSearchesHasErrored,
+  deleteIsLoading: state.deleteSavedSearchIsLoading,
 });
 
 export const mapDispatchToProps = dispatch => ({

src/actions/savedSearch.js

@@ -173,7 +173,6 @@ export function deleteSavedSearch(id) {
           SystemMessages.DELETE_SAVED_SEARCH_SUCCESS_TITLE,
         ));
         dispatch(currentSavedSearch(false));
-        dispatch(savedSearchesFetchData());
       })
       .catch((err) => {
         dispatch(deleteSavedSearchHasErrored(JSON.stringify(propOrDefault(err, 'response.data', 'An error occurred trying to delete this search.'))));