Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sagas #14

Merged
merged 7 commits into from
Dec 7, 2018
Merged

Refactor sagas #14

merged 7 commits into from
Dec 7, 2018

Conversation

burgwyn
Copy link

@burgwyn burgwyn commented Nov 20, 2018 •
edited
Loading

Reducing complexity of loginWatcher

@burgwyn burgwyn changed the title WIP - Refactor sagas Refactor sagas Dec 4, 2018
rtirserio
rtirserio approved these changes Dec 4, 2018
View reviewed changes
Copy link

@rtirserio rtirserio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It takes the complexity to 6 which is still going to raise the warning. I'm but sure if it makes sense to try to reduce this anymore as its pretty simple to follow

@burgwyn burgwyn merged commit 6634f53 into dev Dec 7, 2018
@burgwyn burgwyn deleted the codeclimate_login branch December 7, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtirserio rtirserio rtirserio approved these changes

@mjoyce91 mjoyce91 Awaiting requested review from mjoyce91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@burgwyn @rtirserio