CodeClimate Fixes

src/Components/Favorite/Favorite.jsx

@@ -195,7 +195,6 @@ Favorite.propTypes = {
   hideText: PropTypes.bool,
   compareArray: FAVORITE_POSITIONS_ARRAY.isRequired,
   isLoading: PropTypes.bool,
-  hasErrored: PropTypes.bool,
   hasBorder: PropTypes.bool,
   useLongText: PropTypes.bool,
   useButtonClass: PropTypes.bool,
@@ -209,7 +208,6 @@ Favorite.defaultProps = {
   as: 'div',
   hideText: false,
   isLoading: false,
-  hasErrored: false,
   compareArray: [],
   hasBorder: false,
   useLongText: false,

src/actions/routerLocations.test.js

@@ -1,4 +1,4 @@
-import { first, last } from 'lodash';
+import { last } from 'lodash';
 import * as actions from './routerLocations';
 import routerLocations from '../__mocks__/routerLocations';
 

src/sass/_accessibility.scss

@@ -11,6 +11,11 @@ a {
   }
 }
 
+// scss-lint:disable SelectorFormat
+// The react-picky module uses two underscores in its class names.
+// Instead of modifying the source css, the SelectorFormat rule
+// has been disabled for this file in order to override styles on the
+// default classes.
 *:focus,
 .usa-focus,
 .picky__dropdown > div > .option:focus,

src/sass/_bidderPortfolio.scss

@@ -91,7 +91,12 @@
     }
   }
 
+  // Disable to override the >div:nth-child() styles
+  // scss-lint:disable MergeableSelector
+  // scss-lint:disable QualifyingElement
   > div.client-checkbox-list {
+  // scss-lint:enable MergeableSelector
+  // scss-lint:enable QualifyingElement
     display: flex;
     flex: 16 1 450px;
     flex-wrap: wrap;