Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM-4562: refactoring so that panelmeetingadmin loads panel meeting data indepe… #2589

Merged
merged 15 commits into from
Jun 21, 2023

Conversation

pveland621
Copy link

Refactoring so that loads panel meeting data independently using :pmseqnum from route

ACs:

  1. Verify editing a panel meeting from AO/CDO panel meeting search loads in all fields correctly
  2. Verify editing is disabled if the current date is past the scheduled panel meeting date
  3. Verify all fields can be changed without issue and that the date math is correct:
    • prelim cutoff: panel meeting date minus two days and five minutes
    • addendum cutoff: panel meeting date minus one day and five minutes
  4. Verify edit changes did not affect ability to create new panel meeting
    • Verify defaults for create new panel meeting are correct (should be a locked 'Initiated' status dropdown, and blank everything else)
  5. Verify accessing the edit panel meeting page from a raw URL correctly loads data (e.g. http://localhost:3000/profile/administrator/panel/{panelSeqNum})

Ticket

@M00staff
Copy link
Collaborator

the useEffect's on this guy are mighty slow - can we have the loading spinner keep showing while this is loading?

image

@pveland621
Copy link
Author

the useEffect's on this guy are mighty slow - can we have the loading spinner keep showing while this is loading?
image

done!

@github-actions github-actions bot added size/L and removed size/M labels Jun 20, 2023
Copy link
Collaborator

@M00staff M00staff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a note - stop using lodash.get

I know its mostly out of habit at this point - but its wildly slow vs optional chaining

No need to re-work this guy, just please keep it in mind for the next one 😬

@elizabeth-jimenez
Copy link

When I clear on Edit of a meeting, it all goes disabled

@elizabeth-jimenez
Copy link

Future Iteration: Cache the filters to speed things up a bit (especially when editing, as they are already being pulled for the Panel Search page)

@scott062 scott062 merged commit 5943a5d into dev Jun 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants