-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TM-4562: refactoring so that panelmeetingadmin loads panel meeting data indepe… #2589
Conversation
…ndently using id from route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a note - stop using lodash.get
I know its mostly out of habit at this point - but its wildly slow vs optional chaining
No need to re-work this guy, just please keep it in mind for the next one 😬
src/Components/AdministratorPage/PanelAdmin/PanelMeetingAdmin.jsx
Outdated
Show resolved
Hide resolved
src/Components/AdministratorPage/PanelAdmin/PanelMeetingAdmin.jsx
Outdated
Show resolved
Hide resolved
src/Components/AdministratorPage/PanelAdmin/PanelMeetingAdmin.jsx
Outdated
Show resolved
Hide resolved
When I clear on Edit of a meeting, it all goes disabled |
Future Iteration: Cache the filters to speed things up a bit (especially when editing, as they are already being pulled for the Panel Search page) |
src/Components/AdministratorPage/PanelAdmin/PanelMeetingAdmin.jsx
Outdated
Show resolved
Hide resolved
…hase-Consulting/State-TalentMAP into update/edit-panel-meeting-refactor
Refactoring so that loads panel meeting data independently using
:pmseqnum
from routeACs:
Ticket