Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM-5572] Bidding Tool Integration (Edit) #2856

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Conversation

jlam-mpc
Copy link
Collaborator

@jlam-mpc jlam-mpc commented Feb 13, 2024

Bugs:

  • Incorrect initial form input value states on initial toggle of edit
  • Properly redirect to newly created bidding tool
  • Toggle edit mode off on successful edit save
  • Incorrectly displaying read only values on card

Dual Merge:

TM-5572
TM-5374

@elizabeth-jimenez
Copy link

@jlam-mpc is this ready for review?

@elizabeth-jimenez
Copy link

elizabeth-jimenez commented Feb 26, 2024

pause reviewing: Since this isn't 12.1, going to hold off on reviewing until after

@elizabeth-jimenez elizabeth-jimenez added pause reviewing ready for review, but not the priority and removed pause reviewing ready for review, but not the priority labels Feb 26, 2024
@jlam-mpc jlam-mpc added the pause reviewing ready for review, but not the priority label Mar 26, 2024
@jlam-mpc jlam-mpc self-assigned this May 2, 2024
@github-actions github-actions bot added size/L and removed size/S labels Jun 10, 2024
@jlam-mpc jlam-mpc changed the title [TM-5374] Bidding Tool Integration (Edit) [TM-5572] Bidding Tool Integration (Edit) Jun 10, 2024
@jlam-mpc jlam-mpc removed the pause reviewing ready for review, but not the priority label Jun 11, 2024
@jlam-mpc jlam-mpc merged commit 28283be into dev Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants