Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bid stats on the profile when there are no stats #29

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fix the bid stats on the profile when there are no stats #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Components/BidListResultsCard/BidContent/BidContent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@ import { BID_STATISTICS_OBJECT } from '../../../Constants/PropTypes';
const BidContent = ({ status, positionNumber, postName, positionTitle, bidStatistics }) => (
<div className="usa-grid-full bid-content-container">
<BidStatus status={status} positionTitle={positionTitle} />
{
bidStatistics &&
<span className="bid-stats">
<BidCount bidStatistics={bidStatistics} altStyle label="Bid Count" />
</span>
}
<span className="bid-stats">
<BidCount bidStatistics={bidStatistics} altStyle label="Bid Count" />
</span>
<div>
<span className="bid-list-card-title-position">Position number </span>
<Link to={`/details/${positionNumber}`}>
Expand Down
10 changes: 10 additions & 0 deletions src/Components/BidListResultsCard/BidContent/__snapshots__/BidContent.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ exports[`BidContentComponent matches snapshot 1`] = `
positionTitle="Title"
status="approved"
/>
<span
className="bid-stats"
>
<BidCount
altStyle={true}
bidStatistics={null}
hideLabel={false}
label="Bid Count"
/>
</span>
<div>
<span
className="bid-list-card-title-position"
Expand Down
4 changes: 3 additions & 1 deletion src/Components/BidListResultsCard/BidListResultsCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { get } from 'lodash';
import { BID_OBJECT, EMPTY_FUNCTION } from '../../Constants/PropTypes';
import { NO_POST } from '../../Constants/SystemMessages';
import InformationDataPoint from '../ProfileDashboard/InformationDataPoint';
Expand Down Expand Up @@ -27,6 +28,7 @@ class BidListResultsCard extends Component {
const timeDistanceInWords = getTimeDistanceInWords(bid.update_date);
const contentTitle = timeDistanceInWords && createdDate ?
`${timeDistanceInWords} | Added to Bid List: ${createdDate}` : null;
const bidStatistics = get(bid, 'position.bid_statistics[0]', {});
return (
<div className="usa-grid-full saved-search-card" key={bid.id}>
<div className="usa-grid-full">
Expand All @@ -40,7 +42,7 @@ class BidListResultsCard extends Component {
status={bid.status}
positionNumber={bid.position.position_number}
postName={bid.post || NO_POST}
bidStatistics={bid.position.bid_statistics[0]}
bidStatistics={bidStatistics}
/>
</div>
}
Expand Down