TM-6053-Pub-Pos-Edit-UI #2987
Merged
TM-6053-Pub-Pos-Edit-UI #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagbakwu
requested review from
M00staff,
elizabeth-jimenez,
pveland621,
scott062 and
jlam-mpc
M00staff
reviewed
May 21, 2024
| @@ -154,6 +154,7 @@ const PublishablePositionCard = ({ | |||
| <div className="position-form--input"> | |||
| <label htmlFor="publishable-position-statuses">Publishable Status</label> | |||
| <select | |||
| disabled={disableEditDetails} | |||
There was a problem hiding this comment.
so, the disabled checkbox for the Exclude button has a little no sign show on mouse hover + the disabled discoloration
vs
but, the publishable status looks the same if its disabled or not (this is in dark mode - light mode has a slight grey to the arrow.
vs
def not in the A/C's - but, it might be reasonable to make this distinction somewhat clear to the end user.
M00staff
requested changes
May 21, 2024
M00staff
reviewed
May 21, 2024
Comment on lines
158
to
159
| className="publishable-position-inputs" | ||
| id="publishable-position-statuses" |
There was a problem hiding this comment.
more of a comment - but, why do these have classes & ID's if there isn't any corresponding CSS for them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the UI portion of the publishable positions edit functionality.
Ticket