Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skill Code text to Skill, except on CDO views #31

Merged
merged 1 commit into from
Dec 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`BidCountNumberComponent matches snapshot where type = atSkillBids 1`] =
style={Object {}}
tabIndex="0"
theme="dark"
title="Number of bidders who are at Skill code."
title="Number of bidders who are at Skill."
touchHold={false}
trigger="mouseenter focus"
unmountHTMLWhenHide={false}
Expand Down Expand Up @@ -90,7 +90,7 @@ exports[`BidCountNumberComponent matches snapshot where type = inGradeAtSkillBid
style={Object {}}
tabIndex="0"
theme="dark"
title="Number of bidders who are at Grade and Skill code."
title="Number of bidders who are at Grade and Skill."
touchHold={false}
trigger="mouseenter focus"
unmountHTMLWhenHide={false}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class DraftAlert extends Component {
{post}
</div>
<div>
<span className="title">Skill code: </span>
<span className="title">Skill: </span>
{skillCode}
</div>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ exports[`DraftAlertComponent matches snapshot 1`] = `
<span
className="title"
>
Skill code:
Skill:
</span>
POLITICAL AND ECONOMIC AFFAIRS (6050)
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/Components/CompareList/CompareList.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const CompareList = ({ compare, isLoading }) => {
}
</tr>
<tr>
<th scope="row">Skill code</th>
<th scope="row">Skill</th>
{
compareArray.map(c => (
<td key={shortId.generate()}>{c.skill || NO_SKILL}</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports[`CompareListComponent matches snapshot 1`] = `
<th
scope="row"
>
Skill code
Skill
</th>
<td>
None listed
Expand Down Expand Up @@ -367,7 +367,7 @@ exports[`CompareListComponent matches snapshot when there is an obc id 1`] = `
<th
scope="row"
>
Skill code
Skill
</th>
<td>
None listed
Expand Down
2 changes: 1 addition & 1 deletion src/Components/CondensedCardData/CondensedCardData.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const CondensedCardData = ({ position }) => {
return (
<div className="usa-grid-full condensed-card-data">
<CondensedCardDataPoint
title="Skill code"
title="Skill"
content={position.skill || NO_SKILL}
hasFixedTitleWidth
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`CondensedCardDataComponent matches snapshot 1`] = `
<CondensedCardDataPoint
content="OFFICE MANAGEMENT (9017)"
hasFixedTitleWidth={true}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="Freetown, Sierra Leone"
Expand Down Expand Up @@ -39,7 +39,7 @@ exports[`CondensedCardDataComponent matches snapshot with an empty estimated end
<CondensedCardDataPoint
content="None listed"
hasFixedTitleWidth={true}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="Freetown, Sierra Leone"
Expand Down Expand Up @@ -71,7 +71,7 @@ exports[`CondensedCardDataComponent matches snapshot with an empty skill 1`] = `
<CondensedCardDataPoint
content="None listed"
hasFixedTitleWidth={true}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="Freetown, Sierra Leone"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const HomePageFiltersSection = ({ filters, submitSearch, onFilterSelect, isLoadi
<div className="usa-grid-full">
<Form className="usa-grid-full" onFormSubmit={submitSearch}>
<FieldSet
legend="Search by Skill code"
legend="Search by Skill"
>
<SkillCodeFilter
filters={skillCodesData}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`HomePageFiltersComponent matches snapshot 1`] = `
>
<FieldSet
className=""
legend="Search by Skill code"
legend="Search by Skill"
legendSrOnly={false}
>
<SkillCodeFilter
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class SkillCodeFilter extends Component {
options={sortedOptions}
onChange={this.handleChange}
closeOnSelect={false}
placeholder="Select Skill codes"
placeholder="Select Skills"
isLoading={isLoading}
tabSelectsValue={false /* avoid focus trap */}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`SkillCodeFilterComponent matches snapshot 1`] = `
]
}
pageSize={5}
placeholder="Select Skill codes"
placeholder="Select Skills"
removeSelected={true}
required={false}
rtl={false}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/PositionDetailsItem/PositionDetailsItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const PositionDetailsItem = (props) => {
/>
<div className="usa-grid-full data-point-section">
<CondensedCardDataPoint ariaLabel={getAccessiblePositionNumber(details.position_number)} title="Position number" content={details.position_number} />
<CondensedCardDataPoint title="Skill code" content={details.skill || NO_SKILL} />
<CondensedCardDataPoint title="Skill" content={details.skill || NO_SKILL} />
<CondensedCardDataPoint title="Grade" content={details.grade || NO_GRADE} />
<CondensedCardDataPoint title="Bureau" content={formattedBureau} />
<CondensedCardDataPoint title="Tour of duty" content={formattedTOD} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ exports[`PositionDetailsItem matches snapshot 1`] = `
<CondensedCardDataPoint
content="OFFICE MANAGEMENT (9017)"
hasFixedTitleWidth={false}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="05"
Expand Down Expand Up @@ -254,7 +254,7 @@ exports[`PositionDetailsItem matches snapshot when there is an obc id 1`] = `
<CondensedCardDataPoint
content="OFFICE MANAGEMENT (9017)"
hasFixedTitleWidth={false}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="05"
Expand Down Expand Up @@ -479,7 +479,7 @@ exports[`PositionDetailsItem matches snapshot when various data is missing from
<CondensedCardDataPoint
content="None listed"
hasFixedTitleWidth={false}
title="Skill code"
title="Skill"
/>
<CondensedCardDataPoint
content="None listed"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const FavoriteContent = ({ position }) => (
{position.title}
</div>
<div>
<span className="bid-list-card-title-post">Skill code: </span>
<span className="bid-list-card-title-post">Skill: </span>
{propOrDefault(position, 'skill', NO_SKILL)}
</div>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`FavoriteContentComponent matches snapshot 1`] = `
<span
className="bid-list-card-title-post"
>
Skill code:
Skill:
</span>
OFFICE MANAGEMENT (9017)
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const PositionInformation = ({ assignment }) => {
content={formattedPosition}
/>
<InformationDataPoint
title="Skill code"
title="Skill"
content={formattedSkill}
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ exports[`PositionInformationComponent matches snapshot 1`] = `
className=""
content="CONSTRUCTION ENGINEERING (6218)"
sideBySide={false}
title="Skill code"
title="Skill"
titleOnBottom={false}
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/Components/ResultsCard/ResultsCard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const ResultsCard = (props) => {
/* eslint-disable quote-props */
{
'Bid cycle': getResult(result, 'latest_bidcycle.name', NO_BID_CYCLE),
'Skill code': getResult(result, 'skill', NO_SKILL),
'Skill': getResult(result, 'skill', NO_SKILL),
'Grade': getResult(result, 'grade', NO_GRADE),
'Bureau': getResult(result, 'bureau', NO_BUREAU),
'Post': post,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class ResultsMultiSearchHeader extends Component {
</div>
<div className="usa-width-one-fourth search-results-inputs search-keyword">
<SkillCodeFilter
label="Skill Code"
label="Skill"
isLoading={filtersIsLoading}
filters={skillCodesData}
onFilterSelect={this.onChangeSkills}
Expand Down Expand Up @@ -244,7 +244,7 @@ ResultsMultiSearchHeader.defaultProps = {
filters: [],
defaultFilters: {},
filtersIsLoading: false,
placeholder: 'Location, Skill cone (code), Grade, Language, Position number',
placeholder: 'Location, Skill, Grade, Language, Position number',
userProfile: {},
onFilterChange: EMPTY_FUNCTION,
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`ResultsMultiSearchHeaderComponent matches snapshot 1`] = `
noForm={true}
onChangeText={[Function]}
onSubmitSearch={[Function]}
placeholder="Location, Skill cone (code), Grade, Language, Position number"
placeholder="Location, Skill, Grade, Language, Position number"
submitDisabled={false}
submitText="Search"
type="medium"
Expand All @@ -62,7 +62,7 @@ exports[`ResultsMultiSearchHeaderComponent matches snapshot 1`] = `
]
}
isLoading={false}
label="Skill Code"
label="Skill"
labelSrOnly={false}
onFilterSelect={[Function]}
userSkills={
Expand Down
2 changes: 1 addition & 1 deletion src/Components/ResultsSearchHeader/ResultsSearchHeader.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ ResultsSearchHeader.defaultProps = {
onFilterChange: EMPTY_FUNCTION,
defaultKeyword: '',
labelSrOnly: false,
placeholder: 'Location, Skill cone (code), Grade, Language, Position number',
placeholder: 'Location, Skill, Grade, Language, Position number',
};

export default ResultsSearchHeader;
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`ResultsSearchHeaderComponent matches snapshot 1`] = `
noForm={true}
onChangeText={[Function]}
onSubmitSearch={[Function]}
placeholder="Location, Skill cone (code), Grade, Language, Position number"
placeholder="Location, Skill, Grade, Language, Position number"
submitDisabled={false}
submitText="Search"
type="medium"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('SkillFilterComponent', () => {

const skillCones = {
item: {
title: 'Skill cones',
title: 'Skill',
description: 'skillCone',
endpoint: 'skill/cone/',
selectionRef: 'skillCone',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`SkillCodeList matches snapshot with an array of three items 1`] = `

exports[`SkillCodeList matches snapshot with an empty array 1`] = `
<span>
No Skill codes listed
No Skills listed
</span>
`;

Expand Down
4 changes: 2 additions & 2 deletions src/Constants/BidCountDefinitions.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const BID_COUNT_DEFINITIONS = {
totalBids: { title: 'Total bids', definition: 'Number of bids on this position.' },
inGradeBids: { title: 'In-grade bids', definition: 'Number of bidders who are at Grade.' },
atSkillBids: { title: 'At-skill bids', definition: 'Number of bidders who are at Skill code.' },
inGradeAtSkillBids: { title: 'In-grade and at-skill bids', definition: 'Number of bidders who are at Grade and Skill code.' },
atSkillBids: { title: 'At-skill bids', definition: 'Number of bidders who are at Skill.' },
inGradeAtSkillBids: { title: 'In-grade and at-skill bids', definition: 'Number of bidders who are at Grade and Skill.' },
};

export default BID_COUNT_DEFINITIONS;
2 changes: 1 addition & 1 deletion src/Constants/SystemMessages.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const NO_SAVED_SEARCHES = 'You do not have any saved searches.';
export const NO_SKILL = DEFAULT_TEXT;
export const NO_TOUR_OF_DUTY = DEFAULT_TEXT;
export const NO_USER_LISTED = DEFAULT_TEXT;
export const NO_USER_SKILL_CODE = 'No Skill codes listed';
export const NO_USER_SKILL_CODE = 'No Skills listed';

export const GENERAL_SAVED_SEARCH_ERROR = 'An error occurred trying to save this search.';

Expand Down
4 changes: 2 additions & 2 deletions src/Containers/Home/items.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[
{
"title": "Skill code",
"title": "Skill",
"selectionRef": "skill",
"text": "Choose Skill codes",
"text": "Choose Skill",
"choices": [
{ "code": 1, "description": "accounting" },
{ "code": 2, "description": "economics" },
Expand Down
4 changes: 2 additions & 2 deletions src/actions/filters/filters.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ const { mockStore, mockAdapter } = setupAsyncMocks();
const items = {
filters: [
{ item: {
title: 'Skill code',
title: 'Skill',
sort: 100,
description: 'skill',
endpoint: 'skill/',
selectionRef: 'skill__code__in',
text: 'Choose Skill codes',
text: 'Choose Skill',
},
data: [
],
Expand Down
4 changes: 2 additions & 2 deletions src/reducers/filters/filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ const items =
},
{
item: {
title: 'Skill Cone (Code)',
title: 'Skill',
sort: 200,
description: 'skill',
endpoint: 'skill/',
selectionRef: ENDPOINT_PARAMS.skill,
text: 'Choose Skill codes',
text: 'Choose Skills',
},
data: [
],
Expand Down
4 changes: 2 additions & 2 deletions src/sass/_results.scss
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ $results-container-width: 100% - $filter-container-width;
}

.accordion-checkbox-post,
.accordion-checkbox-skill-cone-code {
.accordion-checkbox-skill {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You even went for the css

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually required! I generate the the css class based on the filter type because they're all styled slightly differently.

.usa-accordion-button {
float: left;
padding-left: 0;
Expand All @@ -511,7 +511,7 @@ $results-container-width: 100% - $filter-container-width;
min-height: 220px;
}

.accordion-checkbox-skill-cone-code,
.accordion-checkbox-skill,
.accordion-checkbox-post,
.accordion-checkbox-bureau {
padding: 0;
Expand Down