-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark mode #459
dark mode #459
Conversation
mjoyce91
commented
Oct 4, 2019
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests to cover the new components, action and reducer. Are we using object.entries?
src/store.js
Outdated
@@ -17,7 +17,7 @@ import IndexSagas from './index-sagas'; | |||
const persistConfig = { | |||
key: 'root', | |||
storage, | |||
whitelist: ['sortPreferences'], // only persist sortPreferences reducer | |||
whitelist: ['preferences', 'darkModePreference'], // only persist sortPreferences reducer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comment
@@ -1,4 +1,5 @@ | |||
import chalk from 'chalk'; | |||
Object.entries = require('object.entries'); // because jest doesn't import babel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -0,0 +1,52 @@ | |||
import React, { Component } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test(s)
@@ -0,0 +1,52 @@ | |||
import React, { Component } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test(s)
@@ -105,6 +106,7 @@ | |||
"node-mocks-http": "^1.7.6", | |||
"node-sass": "^4.7.2", | |||
"object-assign": "4.1.1", | |||
"object.entries": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The darkreader
library uses it, and apparently you have to polyfill it when using Jest.
I'm going to add a new |
@burgwyn see updates |