-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled state for Bid List button #49
Conversation
Something that happened to me but may not be realistic is the button was disabled for a position for which I had already submitted a bid and the Remove from Bid List button was disabled. Unlikely to happen in production but something to consider would be to only disable the Submit Bid button, not the Remove button |
I think you're right actually, a user would also want to be able to remove a bid even if it was in the "un-biddable" status. I believe that could happen in production. |
@afrasier do you have any thoughts on Rob's comment? |
That's a good point; we could add something to the bid object to flag if it is removable? |
@afrasier that would be helpful here and for what I'm working on related to more states where the bid cam be removed (draft through handshake offered). I'm checking client side right now to determine whether or not to show the remove link |
@mjoyce91 I added a can_delete property to the bid in MetaPhase-Consulting/State-TalentMAP-API#16 |
…date and optimize utility function
@rtirserio - just made an update based on your API change. |
Completes TM-314 by adding a disabled state to the Bid List Button on the Position Details page. Relies on API PR MetaPhase-Consulting/State-TalentMAP-API#12.