Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled state for Bid List button #49

Merged
merged 6 commits into from
Jan 7, 2019

Conversation

mjoyce91
Copy link

Completes TM-314 by adding a disabled state to the Bid List Button on the Position Details page. Relies on API PR MetaPhase-Consulting/State-TalentMAP-API#12.

@rtirserio
Copy link

Something that happened to me but may not be realistic is the button was disabled for a position for which I had already submitted a bid and the Remove from Bid List button was disabled. Unlikely to happen in production but something to consider would be to only disable the Submit Bid button, not the Remove button

@mjoyce91
Copy link
Author

I think you're right actually, a user would also want to be able to remove a bid even if it was in the "un-biddable" status. I believe that could happen in production.

@mjoyce91
Copy link
Author

@afrasier do you have any thoughts on Rob's comment?

@afrasier
Copy link

That's a good point; we could add something to the bid object to flag if it is removable?

@rtirserio
Copy link

@afrasier that would be helpful here and for what I'm working on related to more states where the bid cam be removed (draft through handshake offered). I'm checking client side right now to determine whether or not to show the remove link

@rtirserio
Copy link

@mjoyce91 I added a can_delete property to the bid in MetaPhase-Consulting/State-TalentMAP-API#16

@mjoyce91
Copy link
Author

mjoyce91 commented Jan 2, 2019

@rtirserio - just made an update based on your API change.

@mjoyce91 mjoyce91 merged commit 3b249d6 into dev Jan 7, 2019
@burgwyn burgwyn deleted the feature/TM-279-disabled-bid-button branch April 29, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants