Update/add feature flag TM-1453 #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
reviewed
Dec 27, 2019
public/config/config.json
Outdated
| "client_counts": false | ||
| "client_counts": false, | ||
| "cdo_season_filter": false, | ||
| "cdo_bidding": false |
There was a problem hiding this comment.
Let's set both of these to true for now (both here and config_dev.json). We'll update them to false in the State environment
There was a problem hiding this comment.
Done. And I messed up the merge conflicts with the snapshots I believe. What is the best way to handle that? Should I just accept all of the dev changes for snapshots? Or would it work itself out as long as there are no other merge conflicts and I run update snapshots?
There was a problem hiding this comment.
If you have merge conflicts with snapshots, you can just run tests again with --updateSnapshot so that they get overwritten
mjoyce91
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more flags for cdo bidding in addition to the feature flag for the cdo season filter on the CDO dashboard