dev -> staging #74
Merged
dev -> staging #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
commented
Feb 11, 2019
mjoyce91
commented
- react-linkify to to automatically link URLs and email addresses
- referer check
- glossary links
- remove basic auth
- noopener/noreferrer
- favorites card grid
- role wrapper / bidder role
- fix auth redirect loop
…-TalentMAP into fix/search-qa
Chore/performance
…format Update bid list due date to match site-wide format
Remove feedback button site-wide
…faults Update pagination and page size defaults
…links Use react-linkify to automatically hyperlink URLs + email addresses
…tor-link Glossary Editor - Update Links
* Add bundlsize and command * Refine glob * Refine maxSize target
* chore: fix linter is scss file * fix: linter issue
* Delete login form * Update actions * Clean up sagas * Remove isSAML checks * Refactor sagas, CodeClimate fixes * CodeClimate linting * Upate login screen * Simplify index * Change to force external login * get new custom auth working * remove rest of the basic auth refs from server * use env vars for env specific paths
* Create permissions wrapper and conditionally render content based on bidder role * remove default fallback prop
* fix: override some routes for the webpack dev server so auth works for local development * fix: fix the conf so we can use the login.html when running the server in prod mode
Default to true if can_delete property is not found
…nt (#66) * fix: display favorites list as 4 across above the large break point * fix: display favorites list as 4 across above the large break point
* fix: remove the auth redirect loop and clean up reamining references to the LOGIN_MODE * no conditional about url
* chore: remove unnecessary css file from the build output * chore: update docs regarding apache compression config * Update bid list due date to match site-wide format * Use position id instead of position_number to query for position details * chore: remove unused props from components * chore: fix err due to incorrect favicon size in manifest * chore: remove unused props from the Home container * chore: remove unused props from the HomePagePositionsContainer component * fix: update profile page based on qa * Update styles and content in Position Details page based on QA feedback * fix: add logo to saved search title * fix: search page updates from qa * chore: linter fix * chore: fix linter issue * fix: search page updates from qa * chore: linter fix * Remove feedback button site-wide * Use object in state instead of array * Minor edits to Homepage based on QA * fix: make the pagination link clickable area larger * fix: use the correct button style * fix: better accessibility for active pagination tab selection * fix: use correct button design * fix: use lodash get so that non-existent nested property doesn't throw error (#45) * Use lodash get so that non-existent nested property doesn't throw error * Check for details.id so that components don't render with an empty object * Align bid count with data points in ResultsCondensedCard * Show "Available" filter to all users, not just CDOs (#46) * Update dashboard styles and content based on QA * Fix style for bid list container * Move Bid Count in-line with data points on ResultsCard * View More -> View more * Add disabled state for BidListButton based on proposed API updates * Use real properties from API PR, combine strings * Use white for button text color * feature: add remove bid to the bid tracker for draft and submitted bids * add additional status to the canDeleteBid function * Add react-toastify and use with bid list additions/removals (#51) * Add react-toastify and use with bid list additions/removals * More tests for toast-related functionality * Check if bid can be deleted and apply disabled status accordingly; update and optimize utility function * feature: use the can_delete property from the bid rather than calculate client side * Add loading spinner to Bid List button (#52) * Compress us-flag.jpg (#53)
mjoyce91
added a commit
that referenced
this pull request
Mar 7, 2019
* staging: dev -> staging (#74) # Conflicts: # src/Components/GlossaryEditor/GlossaryEditorCard/GlossaryEditorCard.jsx # src/Components/HomePagePositionsList/HomePagePositionsList.jsx # src/Components/HomePagePositionsSection/__snapshots__/HomePagePositionsSection.test.jsx.snap # src/Components/ProfileDashboard/ProfileDashboard.jsx # src/sass/_condensedCard.scss # src/utilities.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.