Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to record audio only #23

Closed
MaxHillebrand opened this issue Aug 27, 2021 · 2 comments · Fixed by #38
Closed

Option to record audio only #23

MaxHillebrand opened this issue Aug 27, 2021 · 2 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@MaxHillebrand
Copy link
Contributor

[I think] by default you record the mp4. This is often useful and alright.
But in many cases, I only want to have mp3 audio only - it would maybe reduce computation, storage and bandwidth.
Would be cool to have a toggle option of what format to record. [Maybe also support .wav etc]

@mwalbeck mwalbeck added the enhancement New feature or request label Aug 27, 2021
@mwalbeck
Copy link
Collaborator

This would definitely be doable, and yes it would reduce the system requirements needed to run the Talked server. An option to choose the format would be great. I currently allow you to specify the audio codec used for the recording, but it would need a bit more work to properly support audio only.

I think at the minimum an option to choose between a lossy and lossless codec would be good, but I doubt it's going to be a lot more work to implement a generic way to specify it as long as it's configured in the Talked server config.

@mwalbeck mwalbeck modified the milestones: v0.3.0, v0.2.0 Sep 7, 2021
@mwalbeck mwalbeck self-assigned this Sep 9, 2021
@mwalbeck mwalbeck added this to To do in 0.2.0 via automation Sep 9, 2021
@mwalbeck mwalbeck moved this from To do to In progress in 0.2.0 Sep 9, 2021
@mwalbeck mwalbeck linked a pull request Sep 9, 2021 that will close this issue
2 tasks
0.2.0 automation moved this from In progress to Done Sep 30, 2021
@MaxHillebrand
Copy link
Contributor Author

Thank you so much @mwalbeck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
0.2.0
Done
Development

Successfully merging a pull request may close this issue.

2 participants