Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interesting behavior for Metacello load using cacheRepository #400

Open
dalehenrich opened this issue Jul 7, 2016 · 2 comments
Open

Interesting behavior for Metacello load using cacheRepository #400

dalehenrich opened this issue Jul 7, 2016 · 2 comments

Comments

@dalehenrich
Copy link
Member

I don't think this is a bug, since the cacheRepository is really intended for use when doing pure fetches and not for doing loads ... with that said, there is nothing to prevent one from attempting to do a load when you've set the cacheRepository ... however as the tests associated with this bug prove, the results will not be what one wants ...
@dalehenrich
Copy link
Member Author

This discovery came while setting up tests for Issue #399 ... and one of the test MetacelloCypressIssue399PackageCacheTestCase>>testIssue400A showed unexpected behavior in that the package was not loaded ... there may be other odd behavior worth exploring some day involving the following:

  • MetacelloFetchingMCSpecLoader>>scheduleFetchFor:nearestReference:
  • MetacelloFetchingMCSpecLoader>>scheduleFetchFor:cachedReference:

neither of these methods schedule a fetch and thus nothing gets added to the directives and nothing is loaded ...

I think the ultimate resolution here will be to disallow a load when a cacheRepository is specified ...

dalehenrich added a commit that referenced this issue Jul 7, 2016
@dalehenrich
#399, #400 add tests cases for these bugs ... with the test cases, I'…
52a834c 
…ve shown that Metacello ignores the package-cache when deciding whether or not to fetch a package from a FileTree repo so at least Metacello will ignore the package-cache during Baseline loads ... did not explore Configuration loads, but they need to follow the mcz repo rules ... Consequently it isn't absolutely necessary to have any special package-cache handling for Cypress packages, but I'm going to leave the code in place
@pdebruic
Copy link
Collaborator

pdebruic commented Feb 4, 2019

I just ran into this for the past weekend. Didn't know about the distinction between fetch and load. Can we add a warning if cacheRepository: is set when doing a load? Proceeding unsets the cacheRepository or something.

pdebruic added a commit to pdebruic/metacello that referenced this issue Feb 5, 2019
@pdebruic
fix for issue Metacello#400. add warning if #cacheRepository: is set …
447cd1b 
…when loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdebruic @dalehenrich