Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from docker as it is deprecated #136

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Eduardo-Morales-Alberti
Copy link
Member

Warning:

time="2024-03-22T08:03:03+01:00" level=warning msg="/var/lib/jenkins/workspace/schaer-schaer_tests_PR-462/docker-compose.yml: version is obsolete"
time="2024-03-22T08:03:03+01:00" level=warning msg="/var/lib/jenkins/workspace/schaer-schaer_tests_PR-462/jenkins/docker-compose.override.yml: version is obsolete"

Solution:
mailcow/mailcow-dockerized#5797 (comment)

Please remove the version line from the docker-compose.yml file and verify that everything still works correctly on your end. Docker has made this line obsolete, which is likely the reason you're facing this issue

@omarlopesino
Copy link
Member

Adding the official information to the pull request to the information https://docs.docker.com/compose/compose-file/04-version-and-name/ . As edu and the issue referenced mentions the version attribute is not neccesary anymore and only used for backwards compatibility. We can remove it, and if any project needs it, it can be manually added to support older versions.

Merging, thanks!

@omarlopesino omarlopesino merged commit 67f393f into 3.x Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants