Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to docker compose V2 #56

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Migrate to docker compose V2 #56

merged 1 commit into from
Apr 1, 2024

Conversation

omarlopesino
Copy link
Member

No description provided.

@omarlopesino
Copy link
Member Author

@rsanzante I've modified the file src/Handler.php to use docker compose V2 but I am not sure if that code is still used. The code does the boilerplate installation but as far as I know that is currently done by drupal boilerplate assistant, isn't it?

@rsanzante
Copy link
Member

Right, the installation process is now done by the assistant. I guess I forgot to remove the code from Scripthor.

Anyway, I think it is ok to change it in this PR, no need to change the PR.

@rsanzante rsanzante merged commit 57060c9 into 2.x Apr 1, 2024
@rsanzante
Copy link
Member

Mystery solved: the PR was against 2.x branch instead of 3.x, where assistant was removed. This is probably because I didn't mark 3.0.0 release as latest so you missed that branch when creating the PR.

I've cherry picked the fix into 4.x, because we consider this a breaking change (removed support for docker compose v1) and published a v4.0.0 release.

@omarlopesino omarlopesino deleted the feature/docker-compose-v2 branch April 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants