Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap from 4.5.3 to 4.6.0 #324

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 24, 2021

Bumps bootstrap from 4.5.3 to 4.6.0.

Commits
  • 38aaf15 [maven-release-plugin] prepare release bootstrap-4.6.0
  • 6fa162a bump to 4.6.0 - fixes #148
  • 494d94e [maven-release-plugin] prepare for next development iteration
  • 8504a6e [maven-release-plugin] prepare release bootstrap-5.0.0-beta1
  • 8066bec bump to 5.0.0-beta1 - fixes #144
  • 0a643e9 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 24, 2021
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #324 (f4605a5) into master (97470cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #324   +/-   ##
=========================================
  Coverage     84.42%   84.42%           
  Complexity      821      821           
=========================================
  Files           165      165           
  Lines          2382     2382           
  Branches        115      115           
=========================================
  Hits           2011     2011           
  Misses          329      329           
  Partials         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97470cd...f4605a5. Read the comment docs.

@hedgehog1833
Copy link
Collaborator

Here we have a problem with some drop-down fields. Spotify-Synchronisation is one example. The navigaiton on the top right works though.

@dependabot dependabot bot force-pushed the dependabot/gradle/org.webjars-bootstrap-4.6.0 branch 2 times, most recently from a047981 to 4d15a52 Compare January 24, 2021 16:17
Bumps [bootstrap](https://github.com/webjars/bootstrap) from 4.5.3 to 4.6.0.
- [Release notes](https://github.com/webjars/bootstrap/releases)
- [Commits](webjars/bootstrap@bootstrap-4.5.3...bootstrap-4.6.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/org.webjars-bootstrap-4.6.0 branch from 4d15a52 to f4605a5 Compare January 24, 2021 16:23
@hedgehog1833
Copy link
Collaborator

Okay bootstrap 4.6 uses popper.js 2 and I'm pretty sure we are importing 1. But the npm repo on maven only has 1. popper 2 is only in bower...

@hedgehog1833
Copy link
Collaborator

Okay the problem is that bootstrap is currently not compatible with popper v2 (see here). We could work around that by pulling popper v1 manually or just wait for a newer bootstrap. Waiting sounds better, they seem to be working on this. I'll close this PR.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/org.webjars-bootstrap-4.6.0 branch January 24, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant